Unify the design and API of RequestQueueStoreSQL and OfflinePageMetadataStoreSQL Link to design: go/paquete-sql-stores-refactoring
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ae5bda04b7bc9a539b568d5cb5d724594102ad6 commit 6ae5bda04b7bc9a539b568d5cb5d724594102ad6 Author: fgorski <fgorski@chromium.org> Date: Mon Sep 12 22:46:09 2016 [Offline pages] OPM SQL store: moving load to constructor, updating read to GetOfflinePages BUG= 645522 Review-Url: https://codereview.chromium.org/2329283002 Cr-Commit-Position: refs/heads/master@{#418083} [modify] https://crrev.com/6ae5bda04b7bc9a539b568d5cb5d724594102ad6/components/offline_pages/offline_page_metadata_store.h [modify] https://crrev.com/6ae5bda04b7bc9a539b568d5cb5d724594102ad6/components/offline_pages/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/6ae5bda04b7bc9a539b568d5cb5d724594102ad6/components/offline_pages/offline_page_metadata_store_sql.cc [modify] https://crrev.com/6ae5bda04b7bc9a539b568d5cb5d724594102ad6/components/offline_pages/offline_page_metadata_store_sql.h [modify] https://crrev.com/6ae5bda04b7bc9a539b568d5cb5d724594102ad6/components/offline_pages/offline_page_model_impl.cc [modify] https://crrev.com/6ae5bda04b7bc9a539b568d5cb5d724594102ad6/components/offline_pages/offline_page_test_store.cc [modify] https://crrev.com/6ae5bda04b7bc9a539b568d5cb5d724594102ad6/components/offline_pages/offline_page_test_store.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b05a65dac0ca761608d8a47fcefe445044c3251 commit 9b05a65dac0ca761608d8a47fcefe445044c3251 Author: fgorski <fgorski@chromium.org> Date: Tue Sep 13 03:31:14 2016 [Offline pages] Refactoring CreateTable method in OPMStoreSQL BUG= 645522 Review-Url: https://codereview.chromium.org/2338483002 Cr-Commit-Position: refs/heads/master@{#418160} [modify] https://crrev.com/9b05a65dac0ca761608d8a47fcefe445044c3251/components/offline_pages/offline_page_metadata_store_sql.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/792cad7f35ea1005cbf27e64c1e428789b60e58b commit 792cad7f35ea1005cbf27e64c1e428789b60e58b Author: fgorski <fgorski@chromium.org> Date: Tue Sep 13 03:51:14 2016 [Offline pages] Removing static sync methods from Metadata SQL store's interface BUG= 645522 Review-Url: https://codereview.chromium.org/2336773002 Cr-Commit-Position: refs/heads/master@{#418163} [modify] https://crrev.com/792cad7f35ea1005cbf27e64c1e428789b60e58b/components/offline_pages/offline_page_metadata_store_sql.cc [modify] https://crrev.com/792cad7f35ea1005cbf27e64c1e428789b60e58b/components/offline_pages/offline_page_metadata_store_sql.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/430911d0e02f663a5df76e470cd8e0ca4b3852f2 commit 430911d0e02f663a5df76e470cd8e0ca4b3852f2 Author: fgorski <fgorski@chromium.org> Date: Tue Sep 13 22:49:54 2016 [Offline pages] OPMStoreSQL: Upgrade to M55, Upgrade refactoring, conversion refactoring Removes the following fields: * offline URL * version * status * user initiated Updates the Upgrade routine; updates conversions between DB row and offline page item. BUG= 645522 Review-Url: https://codereview.chromium.org/2336813002 Cr-Commit-Position: refs/heads/master@{#418397} [modify] https://crrev.com/430911d0e02f663a5df76e470cd8e0ca4b3852f2/components/offline_pages/offline_page_item.cc [modify] https://crrev.com/430911d0e02f663a5df76e470cd8e0ca4b3852f2/components/offline_pages/offline_page_item.h [modify] https://crrev.com/430911d0e02f663a5df76e470cd8e0ca4b3852f2/components/offline_pages/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/430911d0e02f663a5df76e470cd8e0ca4b3852f2/components/offline_pages/offline_page_metadata_store_sql.cc [modify] https://crrev.com/430911d0e02f663a5df76e470cd8e0ca4b3852f2/components/offline_pages/offline_page_metadata_store_sql.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9305bb6b94a0bf9ed2823037bd2c3314a793ecae commit 9305bb6b94a0bf9ed2823037bd2c3314a793ecae Author: fgorski <fgorski@chromium.org> Date: Wed Sep 14 16:43:48 2016 [Offline pages] Splitting Add and Update methods in OPMStore In OfflinePageMetadataStore the following changes: * AddOfflinePage (for single item) is added * UpdateOfflinePages (for multiple items) is added * AddOrUpdateOfflinePage is removed. Resulting changes: * OfflinePageMetadataStoreSQL and OfflinePageTestStore are updated accordingly. * Tests are updated. * OfflinePageModelImpl usage of above functions is updated. BUG= 645522 Review-Url: https://codereview.chromium.org/2339693002 Cr-Commit-Position: refs/heads/master@{#418587} [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_metadata_store.h [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_metadata_store_sql.cc [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_metadata_store_sql.h [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_model_impl.cc [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_model_impl.h [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_test_store.cc [modify] https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae/components/offline_pages/offline_page_test_store.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e80e6778c44ca1395fda39508a4f4fe0624490a commit 0e80e6778c44ca1395fda39508a4f4fe0624490a Author: fgorski <fgorski@chromium.org> Date: Thu Sep 15 17:36:09 2016 [Offline pages] OPMStoreSQL implementation of Add disabling updates BUG= 645522 Review-Url: https://codereview.chromium.org/2331343007 Cr-Commit-Position: refs/heads/master@{#418898} [modify] https://crrev.com/0e80e6778c44ca1395fda39508a4f4fe0624490a/components/offline_pages/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/0e80e6778c44ca1395fda39508a4f4fe0624490a/components/offline_pages/offline_page_metadata_store_sql.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e80d4071d5ae6ab62bfcc85164694beff7cdd357 commit e80d4071d5ae6ab62bfcc85164694beff7cdd357 Author: fgorski <fgorski@chromium.org> Date: Wed Sep 21 00:04:58 2016 [Offline pages] Moving static private methods from RQStoreSQL interface BUG= 645522 Review-Url: https://codereview.chromium.org/2352073003 Cr-Commit-Position: refs/heads/master@{#419906} [modify] https://crrev.com/e80d4071d5ae6ab62bfcc85164694beff7cdd357/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/e80d4071d5ae6ab62bfcc85164694beff7cdd357/components/offline_pages/background/request_queue_store_sql.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c81890adbfc05d426e76e2850e6b07022c58b6b commit 7c81890adbfc05d426e76e2850e6b07022c58b6b Author: fgorski <fgorski@chromium.org> Date: Wed Sep 21 00:54:22 2016 [Offline pages] Updating the UpdateCallback in OPMStoreSQL * Introduces an StoreUdpateResult object to carry the result of update in unique ptr. * Propagates the changes to consumers of the store. * Adds/Updates tests. BUG= 645522 Review-Url: https://codereview.chromium.org/2343743002 Cr-Commit-Position: refs/heads/master@{#419926} [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_item.cc [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_item.h [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_metadata_store.cc [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_metadata_store.h [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_metadata_store_sql.cc [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_model_impl.cc [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_model_impl.h [modify] https://crrev.com/7c81890adbfc05d426e76e2850e6b07022c58b6b/components/offline_pages/offline_page_test_store.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72ae3a4a08e47cdbb0df4e62e7910b83133f5490 commit 72ae3a4a08e47cdbb0df4e62e7910b83133f5490 Author: fgorski <fgorski@chromium.org> Date: Wed Sep 21 17:03:58 2016 [Offline pages] Extracting AddRequest method in RequestQueueStore * Adding AddRequest to RQStoreSQL and RQInMemoryStore * Updating the Add test. BUG= 645522 Review-Url: https://codereview.chromium.org/2356433004 Cr-Commit-Position: refs/heads/master@{#420084} [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue.cc [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue.h [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue_in_memory_store.cc [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue_in_memory_store.h [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue_store.h [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue_store_sql.h [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/request_queue_store_unittest.cc [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/save_page_request.cc [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/background/save_page_request.h [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/offline_page_metadata_store.h [modify] https://crrev.com/72ae3a4a08e47cdbb0df4e62e7910b83133f5490/components/offline_pages/offline_page_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e681b84e34f23f18375d48afa3f249db8768e8b commit 1e681b84e34f23f18375d48afa3f249db8768e8b Author: fgorski <fgorski@chromium.org> Date: Thu Sep 22 05:15:04 2016 [Offline pages] Extracting and templatizing types for store callbacks * Extracting ItemActionStatus, StoreState and StoreUpdateResult to separate header file. * Templatizing StoreUpdateResult, providing implementation * Updating all uses of StoreUpdateResult with OfflinePageItem type of the item. BUG= 645522 Review-Url: https://codereview.chromium.org/2353393002 Cr-Commit-Position: refs/heads/master@{#420264} [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/BUILD.gn [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/background/request_queue_store.h [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_metadata_store.cc [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_metadata_store.h [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_metadata_store_sql.cc [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_model_impl.cc [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_model_impl.h [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_test_store.cc [modify] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_page_types.h [add] https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b/components/offline_pages/offline_store_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c42be44ac50c01d3ff2e472426a57186625a4dc0 commit c42be44ac50c01d3ff2e472426a57186625a4dc0 Author: fgorski <fgorski@chromium.org> Date: Thu Sep 22 17:11:12 2016 [Offline pages] Implementation of RQStore.UpdateRequests with StoreUpdateResult * Creates RequestQueue store specific instantiation of StoreUdpateResult template * Adds UpdateRequests to RequestQueueStore * Remove AddOrUpdateRequest from RequestQueueStore * Updates tests. BUG= 645522 R=petewil@chromium.org Review-Url: https://codereview.chromium.org/2363563002 Cr-Commit-Position: refs/heads/master@{#420377} [modify] https://crrev.com/c42be44ac50c01d3ff2e472426a57186625a4dc0/components/offline_pages/background/request_queue.cc [modify] https://crrev.com/c42be44ac50c01d3ff2e472426a57186625a4dc0/components/offline_pages/background/request_queue_in_memory_store.cc [modify] https://crrev.com/c42be44ac50c01d3ff2e472426a57186625a4dc0/components/offline_pages/background/request_queue_in_memory_store.h [modify] https://crrev.com/c42be44ac50c01d3ff2e472426a57186625a4dc0/components/offline_pages/background/request_queue_store.h [modify] https://crrev.com/c42be44ac50c01d3ff2e472426a57186625a4dc0/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/c42be44ac50c01d3ff2e472426a57186625a4dc0/components/offline_pages/background/request_queue_store_sql.h [modify] https://crrev.com/c42be44ac50c01d3ff2e472426a57186625a4dc0/components/offline_pages/background/request_queue_store_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0674abb71a7737c42f368d6b68d81e86208012e3 commit 0674abb71a7737c42f368d6b68d81e86208012e3 Author: fgorski <fgorski@chromium.org> Date: Sat Oct 01 01:57:24 2016 [Offline pages] Introduces TaskQueue to serialize tasks that asynchronously access SQLStore * Adds a TaskQueue and Task interface * Adds tests for TaskQueue. * Introduces a core/ directory under components/offline_pages BUG= 645522 , 651238 R=dimich@chromium.org Review-Url: https://codereview.chromium.org/2359933007 Cr-Commit-Position: refs/heads/master@{#422269} [modify] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/BUILD.gn [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/BUILD.gn [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task.cc [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task.h [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_queue.cc [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_queue.h [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_queue_unittest.cc [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_unittest.cc [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/test_task.cc [add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/test_task.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a98a5ef6b896c298d56f941108ce8df56ef0fde commit 1a98a5ef6b896c298d56f941108ce8df56ef0fde Author: fgorski <fgorski@chromium.org> Date: Sat Oct 01 14:44:44 2016 [Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState * Creates a task to change requests state with tests * Updates how RequestQueue performs ChangeRequestsState * Removes ChangeRequestsState from the store BUG= 645522 , 651238 Review-Url: https://codereview.chromium.org/2372043002 Cr-Commit-Position: refs/heads/master@{#422316} [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/BUILD.gn [add] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/change_requests_state_task.cc [add] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/change_requests_state_task.h [add] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/change_requests_state_task_unittest.cc [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_coordinator.h [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue.cc [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue.h [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_in_memory_store.cc [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_in_memory_store.h [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store.h [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store_sql.h [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store_unittest.cc [modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53a9dfb296541463919a998fe30f2756cec2f0d1 commit 53a9dfb296541463919a998fe30f2756cec2f0d1 Author: fgorski <fgorski@chromium.org> Date: Sat Oct 01 15:01:47 2016 [Offline pages] Applying StoreState to track RequestQueueStore state BUG= 645522 Review-Url: https://codereview.chromium.org/2379353003 Cr-Commit-Position: refs/heads/master@{#422317} [modify] https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1/components/offline_pages/background/request_queue_in_memory_store.cc [modify] https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1/components/offline_pages/background/request_queue_in_memory_store.h [modify] https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1/components/offline_pages/background/request_queue_store.h [modify] https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/53a9dfb296541463919a998fe30f2756cec2f0d1/components/offline_pages/background/request_queue_store_sql.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1608da81a4ab410f761786df0b6113afa5ce0cd commit e1608da81a4ab410f761786df0b6113afa5ce0cd Author: fgorski <fgorski@chromium.org> Date: Thu Oct 06 06:21:09 2016 [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue * Switching the interface of RequestQueue/RequestStore::RemoveRequests * Converting implementation to Task based: RemoveRequestsTask with tests. * Removing most of old callbacks and typedefs BUG= 645522 , 651238 Review-Url: https://codereview.chromium.org/2373933003 Cr-Commit-Position: refs/heads/master@{#423448} [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/android/offline_pages/offline_page_bridge.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/BUILD.gn [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/BUILD.gn [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/change_requests_state_task_unittest.cc [add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task.cc [add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task.h [add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task_unittest.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator.h [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator_unittest.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_picker.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_picker.h [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue.h [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_in_memory_store.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_in_memory_store.h [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store.h [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_sql.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_sql.h [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_unittest.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_unittest.cc [modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/offline_store_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad4d36cdf36c91116305989c9d65b13d44bcf982 commit ad4d36cdf36c91116305989c9d65b13d44bcf982 Author: fgorski <fgorski@chromium.org> Date: Wed Oct 19 20:39:04 2016 [Offline pages] Dropping bburns from TODOs and histogram ownership Replacing bburns with fgorski everyhere (TODOs and histograms). BUG= 645522 TBR=asvitkine@chromium.org R=dimich@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2437813002 Cr-Commit-Position: refs/heads/master@{#426273} [modify] https://crrev.com/ad4d36cdf36c91116305989c9d65b13d44bcf982/components/offline_pages/offline_page_metadata_store_sql.cc [modify] https://crrev.com/ad4d36cdf36c91116305989c9d65b13d44bcf982/components/offline_pages/offline_page_model_impl.cc [modify] https://crrev.com/ad4d36cdf36c91116305989c9d65b13d44bcf982/tools/metrics/histograms/histograms.xml
[Automated comment] removing mislabelled merge-merged-2840
Comment 1 by bugdroid1@chromium.org
, Sep 12 2016