New issue
Advanced search Search tips

Issue 645497 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 645492



Sign in to add a comment

Headers values are not combined correctly

Project Member Reported by jakearchibald@chromium.org, Sep 9 2016

Issue description

http://jsbin.com/tiyuxo/edit?js,console

Appending headers of the same name should have their values joined by ','.

Firefox also gets this wrong, but Safari gets it right(ish).
 
See also:  issue 670439 

Status: Available (was: Untriaged)
blink::Headers::get() must be updated.

Headers.get()'s semantics have been changed on this commit in Jan.

https://github.com/whatwg/fetch/issues/189
https://github.com/whatwg/fetch/commit/42464c8c
Labels: -Type-Bug Type-Feature
 bug 645492  (deprecation of getAll()) is blocked on this.

Blocking: 645492

Comment 7 by coron...@gmail.com, Dec 17 2016

On going CL for this issue.
https://codereview.chromium.org/2587463002/
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ad32cbf574e3d263b64f1888520b9158798d41b

commit 7ad32cbf574e3d263b64f1888520b9158798d41b
Author: corona10 <corona10@gmail.com>
Date: Tue Dec 20 07:55:46 2016

Appending headers of the same name should have their values
joined by ','.
Now, FetchHeaderList::get() is iterating all header list and
append strings to a result joined by ','.

BUG= 645497 

Review-Url: https://codereview.chromium.org/2587463002
Cr-Commit-Position: refs/heads/master@{#439743}

[modify] https://crrev.com/7ad32cbf574e3d263b64f1888520b9158798d41b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
[modify] https://crrev.com/7ad32cbf574e3d263b64f1888520b9158798d41b/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp
[modify] https://crrev.com/7ad32cbf574e3d263b64f1888520b9158798d41b/third_party/WebKit/Source/modules/fetch/Headers.cpp

Status: Fixed (was: Available)
Fixed by ad32cbf574e3d263b64f1888520b9158798d41b.
Labels: M-57

Sign in to add a comment