It's no longer part of the spec (https://github.com/whatwg/fetch/commit/42464c)
corona10@gmail.com is working on this issue. - https://codereview.chromium.org/2593673002/ - https://codereview.chromium.org/2591723003/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/673306fb8007e128a1217dff1bfb22acc61262be commit 673306fb8007e128a1217dff1bfb22acc61262be Author: corona10 <corona10@gmail.com> Date: Thu Dec 22 07:30:38 2016 To measue usage of Headers.prototype.getAll(). We need to add use counter for Headers.prototype.getAll(). BUG= 645492 Review-Url: https://codereview.chromium.org/2593673002 Cr-Commit-Position: refs/heads/master@{#440351} [modify] https://crrev.com/673306fb8007e128a1217dff1bfb22acc61262be/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/673306fb8007e128a1217dff1bfb22acc61262be/third_party/WebKit/Source/modules/fetch/Headers.idl [modify] https://crrev.com/673306fb8007e128a1217dff1bfb22acc61262be/tools/metrics/histograms/histograms.xml
Issue 696008 has been merged into this issue.
Can I proceed this issue? We can deprecated and remove this API. (https://www.chromestatus.com/metrics/feature/timeline/popularity/1724)
Yes! Can you send the intent-to-deprecated-and-remove mail to blink-dev@?
Agreed. I double checked that the data is not broken but just recording very low number by looking at the internal version which shows the raw number.
I sent private mail to @chromium.org to discuss sending intent-to-deprecated-and-remove mail. (I am new to send intent mail to blink-dev PTAL)
Intent is now going on https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/x3YXciXQWM0
Was a patch ever sent? This is blocking another spec-compliance change I'd like to make (dropping Headers from the HeadersInit typedef), but getAll's presence breaks some tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73dde766a935605604b2d7cca45033f8dbd9c6fb commit 73dde766a935605604b2d7cca45033f8dbd9c6fb Author: corona10 <corona10@gmail.com> Date: Fri Apr 28 16:27:32 2017 Remove Headers.prototype.getAll() It's no longer part of the spec (https://github.com/whatwg/fetch/commit/42464c) intent-to-deprecate-and-remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/x3YXciXQWM0 BUG= 645492 Review-Url: https://codereview.chromium.org/2591723003 Cr-Commit-Position: refs/heads/master@{#468022} [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/Source/modules/fetch/Headers.cpp [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/Source/modules/fetch/Headers.h [modify] https://crrev.com/73dde766a935605604b2d7cca45033f8dbd9c6fb/third_party/WebKit/Source/modules/fetch/Headers.idl
This is done by corona10@gmail.com. Thank you!
Awesome, thanks a lot!
This is done in M60. Updating bug milestone and the chromestatus entry: https://www.chromestatus.com/admin/features/edit/5656023951998976
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ca0c3f9db962f3a061a30a2d5d27cf9c77253c commit 16ca0c3f9db962f3a061a30a2d5d27cf9c77253c Author: Haeun Kim <ggrace.kim93@gmail.com> Date: Tue Oct 09 11:35:04 2018 Fetch: Remove FetchHeaderList.GetAll() Since FetchHeaderList.GetAll() isn't used any more. We should remove it before someone use this API for other purpose. Bug: 645492 Change-Id: I6c9078eb6314b1cc061b3a4b58c553d90a76b6b8 Reviewed-on: https://chromium-review.googlesource.com/c/1267295 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#597882} [modify] https://crrev.com/16ca0c3f9db962f3a061a30a2d5d27cf9c77253c/third_party/blink/renderer/core/fetch/fetch_header_list.cc [modify] https://crrev.com/16ca0c3f9db962f3a061a30a2d5d27cf9c77253c/third_party/blink/renderer/core/fetch/fetch_header_list.h [modify] https://crrev.com/16ca0c3f9db962f3a061a30a2d5d27cf9c77253c/third_party/blink/renderer/core/fetch/fetch_header_list_test.cc [modify] https://crrev.com/16ca0c3f9db962f3a061a30a2d5d27cf9c77253c/third_party/blink/renderer/core/fetch/fetch_response_data_test.cc
Comment 1 by tyoshino@chromium.org
, Dec 7 2016Status: Available (was: Untriaged)
Summary: Remove Headers.prototype.getAll() (was: Remove Headers.prototype.getAll)