New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645489 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Chromedriver desktop bots are dead

Project Member Reported by gmanikpure@chromium.org, Sep 9 2016

Issue description

Labels: -Pri-3 Pri-0
Error from the bot logs:-

Traceback (most recent call last):
  File "E:\b\build\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\run.py", line 428, in run
    recipe_result = recipe_script.run(api, api._engine.properties)
  File "E:\b\build\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 59, in run
    self.RunSteps, properties, self.PROPERTIES, api=api)
  File "E:\b\build\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 514, in invoke_with_properties
    **additional_args)
  File "E:\b\build\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 475, in _invoke_with_properties
    return callable_obj(*props, **additional_args)
  File "E:\b\build\scripts/slave\recipes\chromium.chromedriver.recipe_autogen.py", line 332, in RunSteps
    dispatch_directory[api.properties["buildername"]](api)
  File "E:\b\build\scripts/slave\recipes\chromium.chromedriver.recipe_autogen.py", line 206, in Win7_steps
    result = api.bot_update.ensure_checkout()
  File "E:\b\build\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 239, in _inner
    return func(*a, **kw)
  File "E:\b\build\scripts\slave\.recipe_deps\depot_tools\recipe_modules\bot_update\api.py", line 287, in ensure_checkout
    co_root = step_result.json.output['root']
KeyError: 'root'


Increasing the priority since this is blocking a ChromeDriver release.
Labels: -Pri-0 Pri-1
I think we can drop this back to Pri-1, since the release went out for Windows, Mac and Linux64. It's only Linux32 that's being delayed, so as long as this gets in the next few hours we're OK.

It's failing on the bot_update step, apparently a clobber is needed:

Traceback (most recent call last):
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/git_cache.py", line 735, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/git_cache.py", line 730, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/git_cache.py", line 603, in CMDpopulate
    mirror.populate(**kwargs)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/git_cache.py", line 439, in populate
    self._fetch(tempdir or self.mirror_path, verbose, depth)
  File "/b/build/scripts/slave/.recipe_deps/depot_tools/git_cache.py", line 414, in _fetch
    raise ClobberNeeded()  # Corrupted cache.
__main__.ClobberNeeded

Cc: aga...@chromium.org
Gauri just noticed that it's looking for svn and failing:

running "git config remote.origin.url svn://svn.chromium.org/chrome-internal/trunk/src-internal" in "/b/build/slave/cache_dir/_cache_tmpK0fpMCsvn.chromium.org-chrome--internal-trunk-src--internal"
...
fatal: Unable to find remote helper for 'svn'

It seems we're still using svn for src-internal on these bots? So this could've started failing with:

https://chromium.googlesource.com/chromium/tools/depot_tools/+/3454ae85da8913a18a67adaaf8727fa9783127d3%5E%21/#F0

Aaron, do you know more about what's going on?

Comment 4 by d...@chromium.org, Sep 9 2016

Cc: iannucci@chromium.org
+iannucci@, who has also been working on bot_update.

SVN is no longer supported, so the waterfall's configuration should be updated to use Git.

Comment 5 by d...@chromium.org, Sep 9 2016

That said, it's not a bad idea to have "bot_update" assert that the remote URL begins with http(s)?://.

Comment 8 by d...@chromium.org, Sep 9 2016

I believe so, yeah.
Status: Fixed (was: Untriaged)
Yep, on all platforms. Thanks for helping, I think we can close this.
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 9 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 9 2016

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4014f09212f4990c4bcdeab8310f395afe2540

commit ca4014f09212f4990c4bcdeab8310f395afe2540
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 09 18:09:59 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/952fb11cc386ad63d59988122c023ec3f7619ab9 Change src-internal from svn to git on chromedriver bots. (samuong@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 645489 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2323403002
Cr-Commit-Position: refs/heads/master@{#417633}

[modify] https://crrev.com/ca4014f09212f4990c4bcdeab8310f395afe2540/infra/config/recipes.cfg

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/1d1abc149f10b50ba6c8e0ed8ec329b04691bb98

commit 1d1abc149f10b50ba6c8e0ed8ec329b04691bb98
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 09 18:14:01 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/952fb11cc386ad63d59988122c023ec3f7619ab9 Change src-internal from svn to git on chromedriver bots. (samuong@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 645489 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2324243002

[modify] https://crrev.com/1d1abc149f10b50ba6c8e0ed8ec329b04691bb98/infra/config/recipes.cfg

Sign in to add a comment