New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645463 link

Starred by 2 users
Status: WontFix
Owner:
rsesek@chromium.org
Closed: Mar 2017
Cc:
dpranke@chromium.org
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 615107



Sign in to add a comment

Reorganize //chrome Mac build

Project Member Reported by rsesek@chromium.org, Sep 9 2016 
The Chromium Mac build has scripts in //chrome/tools/build/mac, //chrome/tools/mac_helpers, and //chrome/app. There's not a good reason for them to be spread out and they could be centralized to a single directory.

In addition, the Mac-specific packaging logic in //chrome/BUILD.gn is close to 600 lines. Splitting this out to a separate GN file would make the overall BUILD.gn file easier to read, and it would allow for more finer-grained reviews.

My current thought is to create //chrome/build/mac and move all the scripts into there. Then add a new BUILD.gn file there as well, into which I can split the Mac packaging rules from //chrome/BUILD.gn.

Brett/Dirk: Does that sound reasonable? Would other platforms benefit from splitting out their rules, or is Mac the only platform with complicated packaging needs?

Comment 1 by rsesek@chromium.org, Mar 31 2017

Status: WontFix (was: Assigned)
I'm going to WontFix this for now. In  issue 615107  I rationalized the locations for many of our scripts.

I would still like to split all the Mac packaging stuff out of chrome/BUILD.gn, but it cannot go into something like chrome/chrome_mac.gni since targets cannot be import()ed in GN. And I don't think making a //chrome/build/mac/BUILD.gn file really makes sense unless other platforms also wanted to do the same.
►

Sign in to add a comment