Currently, the VariationParamsManager does not allow to associate parameters to features in unit-tests. This should be fixed.
(Just following this as I need it, too)
This was on hold for very long. I have a CL ready, hope to get back to it soon.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce21e97f5e7a87e3cef9459dd578279e24f553d8 commit ce21e97f5e7a87e3cef9459dd578279e24f553d8 Author: jkrcal <jkrcal@chromium.org> Date: Mon Dec 05 22:36:45 2016 Extend VariationParamsManager to support feature associations. Previously, feature associations for variation parameters were not easy to register in unit-tests. This CL extends VariationParamsManager to do it automatically. BUG= 645447 Review-Url: https://codereview.chromium.org/2321273003 Cr-Commit-Position: refs/heads/master@{#436433} [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/chrome/browser/chromeos/hats/hats_finch_helper_unittest.cc [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/chrome/test/BUILD.gn [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/ntp_snippets/remote/ntp_snippets_fetcher_unittest.cc [add] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/ntp_snippets/remote/ntp_snippets_status_service.h [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/variations/BUILD.gn [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/variations/variations_associated_data.cc [modify] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/variations/variations_associated_data.h [add] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/variations/variations_params_manager.cc [add] https://crrev.com/ce21e97f5e7a87e3cef9459dd578279e24f553d8/components/variations/variations_params_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cd568f54d8de0e9daab1c25cfe0dc5056e0f234 commit 2cd568f54d8de0e9daab1c25cfe0dc5056e0f234 Author: jkrcal <jkrcal@chromium.org> Date: Tue Dec 06 12:00:34 2016 Add another unittest for configuring sign-in dependency. This test is made possible by adding feature associations to VariationParamsManager. BUG= 645447 Review-Url: https://codereview.chromium.org/2556543003 Cr-Commit-Position: refs/heads/master@{#436573} [delete] https://crrev.com/e591a5fb9a0015e7dcd71e566f2914233aaea35e/components/ntp_snippets/remote/ntp_snippets_status_service.h [modify] https://crrev.com/2cd568f54d8de0e9daab1c25cfe0dc5056e0f234/components/ntp_snippets/remote/remote_suggestions_status_service.h [modify] https://crrev.com/2cd568f54d8de0e9daab1c25cfe0dc5056e0f234/components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc
Comment 1 by jkrcal@chromium.org
, Sep 9 2016