Regression: Search bubble is not after typing 'yahoo' in 'Search' field.
Reported by
jshan...@etouch.net,
Sep 9 2016
|
|||
Issue descriptionChrome Version: 55.0.2855.0 (Official Build) 1f84049641ac0f80af74361acd0ea0df338479c4-refs/heads/master@{#417475} (32/64 bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) Steps: 1. Launch Chrome and navigate to chrome://md-settings. 2. Click on 'Manage Search engine' (make sure yahoo.com is in list of search engine) 3. Now type 'yahoo' in 'Search' field and observe. Actual: Yellow search bubble is not seen after typing 'yahoo' in 'Search' field. Expected: Yellow search bubble is not seen after typing 'yahoo' in 'Search' field. This is a regression issue broken in M-54, will soon update bisect info. Good build: 54.0.2832.0 Bad build: 54.0.2833.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/3839dbc4efacbba65f5d395301f2fecb9c58c1fa..01fae36efcb5eadacbd2fb8396456645a104876b?pretty=fuller&n=100 Suspecting: r412896 ? Please help to re-assign if your change is not the cause.
,
Sep 12 2016
,
Sep 20 2016
The contents of an iron-list are ignored during searching, see https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search_settings.js?l=32. This was not the case when dom-repeat was used, so the searching algorithm was finding the 'yahoo.com' string and it was surfacing it with a search bubble. We are not planning to search the contents of iron-list, or other lists that are dynamically populated, so the described behavior is justified. |
|||
►
Sign in to add a comment |
|||
Comment 1 by steve...@chromium.org
, Sep 12 2016Owner: dschuyler@chromium.org