Mainly replacing ASSERT with DCHECK, but will also resolve other presubmit checks, where looks reasonable.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fc1b2f026bdd7869b9db224b87bafddbea7fb27 commit 1fc1b2f026bdd7869b9db224b87bafddbea7fb27 Author: hiroshige <hiroshige@chromium.org> Date: Fri Sep 09 11:30:59 2016 Replace ASSERT*() with DCHECK*() in core/xmlhttprequest/ BUG= 645395 , 596760 Review-Url: https://codereview.chromium.org/2325093002 Cr-Commit-Position: refs/heads/master@{#417558} [modify] https://crrev.com/1fc1b2f026bdd7869b9db224b87bafddbea7fb27/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp [modify] https://crrev.com/1fc1b2f026bdd7869b9db224b87bafddbea7fb27/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp [modify] https://crrev.com/1fc1b2f026bdd7869b9db224b87bafddbea7fb27/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f8df031140d9a63f3d3b7932b79fd4de1391b8d commit 1f8df031140d9a63f3d3b7932b79fd4de1391b8d Author: hiroshige <hiroshige@chromium.org> Date: Tue Sep 13 09:24:59 2016 Fix "More than one command on the same line" presubmit errors: core/fetch,loader This CL fixes presubmit errors in core/fetch and core/loader: More than one command on the same line [whitespace/newline] Style fix only. BUG= 645395 Review-Url: https://codereview.chromium.org/2324033004 Cr-Commit-Position: refs/heads/master@{#418206} [modify] https://crrev.com/1f8df031140d9a63f3d3b7932b79fd4de1391b8d/third_party/WebKit/Source/core/fetch/FetchUtils.cpp [modify] https://crrev.com/1f8df031140d9a63f3d3b7932b79fd4de1391b8d/third_party/WebKit/Source/core/fetch/Resource.h [modify] https://crrev.com/1f8df031140d9a63f3d3b7932b79fd4de1391b8d/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h [modify] https://crrev.com/1f8df031140d9a63f3d3b7932b79fd4de1391b8d/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/1f8df031140d9a63f3d3b7932b79fd4de1391b8d/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4c242bce2dd77f07a5d2b051088688f1ebbab86 commit b4c242bce2dd77f07a5d2b051088688f1ebbab86 Author: hiroshige <hiroshige@chromium.org> Date: Wed Sep 14 17:38:55 2016 Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ sed -i 's/ ASSERT(/ DCHECK(/g' sed -i 's/ RELEASE_ASSERT(/ CHECK(/g' sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g' sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g' perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g' for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`. This CL replaces - DCHECK(a == b) with DCHECK_EQ(a, b) - DCHECK(a && b) with DCHECK(a) and DCHECK(b) etc. manually. BUG= 645395 , 596760 Review-Url: https://codereview.chromium.org/2327643003 Cr-Commit-Position: refs/heads/master@{#418606} [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/DocumentResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/FetchRequest.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/FontResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ImageResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/MemoryCache.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/RawResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/RawResource.h [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/Resource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/ScriptResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/DocumentWriter.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FormSubmission.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameFetchContext.h [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/HistoryItem.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/HttpEquiv.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ImageLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/LinkLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/NavigationScheduler.h [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ProgressTracker.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ThreadableLoader.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp [modify] https://crrev.com/b4c242bce2dd77f07a5d2b051088688f1ebbab86/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78973d58d3ba0f7780ca1cb4919465490c377c17 commit 78973d58d3ba0f7780ca1cb4919465490c377c17 Author: hiroshige <hiroshige@chromium.org> Date: Fri Sep 30 06:43:48 2016 Add explicit to core/fetch, core/loader and modules/websockets BUG= 645395 Review-Url: https://codereview.chromium.org/2377253002 Cr-Commit-Position: refs/heads/master@{#422047} [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/fetch/DocumentResourceReference.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/fetch/LinkFetchResource.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/fetch/RawResource.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/fetch/Resource.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/fetch/ResourceFetcher.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/FormSubmission.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/FrameLoader.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/ProgressTracker.cpp [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/SinkDocument.cpp [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/SinkDocument.h [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp [modify] https://crrev.com/78973d58d3ba0f7780ca1cb4919465490c377c17/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e24cb90223c91a1ffdf8026e9494c851504c9a6b commit e24cb90223c91a1ffdf8026e9494c851504c9a6b Author: hiroshige <hiroshige@chromium.org> Date: Fri Sep 30 07:51:56 2016 Replace ASSERT*() with DCHECK*() in modules/websockets BUG= 645395 , 596760 Review-Url: https://codereview.chromium.org/2325983002 Cr-Commit-Position: refs/heads/master@{#422061} [modify] https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp [modify] https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp [modify] https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp [modify] https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b/third_party/WebKit/Source/modules/websockets/WebSocketChannel.cpp [modify] https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp [modify] https://crrev.com/e24cb90223c91a1ffdf8026e9494c851504c9a6b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa58507933dfd19c9ad4f0d5a9d39cdaf52ad635 commit aa58507933dfd19c9ad4f0d5a9d39cdaf52ad635 Author: yhirano <yhirano@chromium.org> Date: Thu Oct 20 05:40:20 2016 Do not use boolean bitfields in blink::Resource The presubmit script says a class should not have both unsigned an boolean bitfields[runtime/bitfields]. R=hiroshige@chromium.org BUG= 645395 Review-Url: https://chromiumcodereview.appspot.com/2413983002 Cr-Commit-Position: refs/heads/master@{#426417} [modify] https://crrev.com/aa58507933dfd19c9ad4f0d5a9d39cdaf52ad635/third_party/WebKit/Source/core/fetch/Resource.cpp [modify] https://crrev.com/aa58507933dfd19c9ad4f0d5a9d39cdaf52ad635/third_party/WebKit/Source/core/fetch/Resource.h
The remaining part is modules/fetch (I postponed it because there was major refactoring by yhirano@).
Closing as Issue 707652 is opened for modules/fetch.
Comment 1 by bugdroid1@chromium.org
, Sep 9 2016