New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645367 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Tooltip on pdf icon is not displayed properly.

Reported by vku...@etouch.net, Sep 9 2016

Issue description

Chrome Version:55.0.2854.2 (Official Build)Revision f75e29a598998d720366ce93737d69236f49e980-refs/branch-heads/2854@{#2} (32/64-bit)
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://cb.vu/unixtoolbox.pdf
(2)Hover mouse on pdf icon from top R.H.S of page and observe.

Actual: Tooltip on pdf icon is not displayed properly (i.e appears to be chopped)

Expected: Tooltip on pdf icon should be properly displayed.

This is a regression issue broken in 'M55' and will soon update other info.

 

Comment 1 by vku...@etouch.net, Sep 9 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 55.0.2844.0 
Bad Build:  55.0.2845.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/b8cd385fb7004724f431d99af4f410adcd51888e..19cd3064a23e7e953cafe855086c0aa9ce54dc7a?pretty=fuller&n=1000

Suspecting: 414946 ?
Kindly help to re-assign, if your changes are not cause for this issue.
Actual_PDF.png
96.1 KB View Download
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
You got the right person, but for the wrong reason. I have no idea how you decided, but r414946 is very likely not the cause.

Also, bisecting to 55.0.2844.0 vs 55.0.2845.0 means there are ~1000 commits to look through. That is not a "narrow bisect".
Labels: -Pri-1 -ReleaseBlock-Stable -Type-Bug-Regression OS-Chrome Pri-2 Type-Bug
We started to display PDF popup annotations as a result of fixing parts of  bug 62625 . So now we have some annotations that pop up, but sometimes they get cut off like this.
Labels: -M-55 M-59
 Issue 693927  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/3b20ec77c760ef11dacf00a3e654d06cadf20c27

commit 3b20ec77c760ef11dacf00a3e654d06cadf20c27
Author: Jane Liu <janeliulwq@google.com>
Date: Mon Aug 21 16:04:57 2017

Avoid annotation popups to be clipped at page edges

Currently, annotation popups are placed at a fixed location relative to
the annotation. If an annotation is too much on the right or the bottom
of the page, then its popup will be clipped at the edge of the page.

This CL translates the popups appropriately to avoid getting clipped at
page edges. Also, if an annotation is at the bottom-right corner of the
page, then the popup is placed above and to the left of the annotation,
instead of below and to the right of it.

See a set of comparison screenshots here:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGZXZXR05yVEFWSlE?usp=sharing

Bug= chromium:645367 ,pdfium:750

Change-Id: Ie048281e965523c292dcc704b51188d794f8877b
Reviewed-on: https://pdfium-review.googlesource.com/11470
Commit-Queue: Jane Liu <janeliulwq@google.com>
Reviewed-by: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/3b20ec77c760ef11dacf00a3e654d06cadf20c27/core/fpdfdoc/cpdf_annotlist.cpp

Labels: -M-59 M-62
Owner: ----
Status: Fixed (was: Assigned)

Sign in to add a comment