Change screenshot notification text to "Show in folder" |
||||||||
Issue descriptionCurrently, screenshot notifications say "Click to view", but instead of showing the image when clicked it instead opens the Files.app and highlights the file. Since that is the desired behavior, we should change the notification text to "Show in folder". Note that there are 3 different ways to take a screenshot: Ctrl+F5 (full screenshot), Ctrl+Shift+F5 (select region), Ctrl+Alt+F5 (select window) @derat can you fix this since you've made other changes to the notifications recently?
,
Sep 9 2016
,
Sep 9 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66305867df01ed056de4d0e5edd50dbe25571ea2 commit 66305867df01ed056de4d0e5edd50dbe25571ea2 Author: derat <derat@chromium.org> Date: Fri Sep 09 18:35:32 2016 chromeos: Update screenshot notification to "Show in folder" Change the screenshot notification's misleading "Click to view" text to the more-accurate "Show in folder". BUG= 645356 Review-Url: https://codereview.chromium.org/2327863002 Cr-Commit-Position: refs/heads/master@{#417645} [modify] https://crrev.com/66305867df01ed056de4d0e5edd50dbe25571ea2/ash/ash_chromeos_strings.grdp
,
Sep 9 2016
Thanks Dan! This'll be merged into M54 too, right?
,
Sep 9 2016
Uh, I can merge it if we set the correct labels. :-)
,
Sep 9 2016
And thank you for dropping my label changes, Monorail. >:-(
,
Sep 10 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/497ef4df39aced4f3101084f41bd011e9cfe3228 commit 497ef4df39aced4f3101084f41bd011e9cfe3228 Author: Daniel Erat <derat@chromium.org> Date: Tue Sep 13 18:09:26 2016 chromeos: Update screenshot notification to "Show in folder" Change the screenshot notification's misleading "Click to view" text to the more-accurate "Show in folder". BUG= 645356 Review-Url: https://codereview.chromium.org/2327863002 Cr-Commit-Position: refs/heads/master@{#417645} (cherry picked from commit 66305867df01ed056de4d0e5edd50dbe25571ea2) Review URL: https://codereview.chromium.org/2333373002 . Cr-Commit-Position: refs/branch-heads/2840@{#333} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/497ef4df39aced4f3101084f41bd011e9cfe3228/ash/ash_chromeos_strings.grdp
,
Sep 13 2016
,
Sep 21 2016
8743.35.0 / 54.0.2840.33
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/497ef4df39aced4f3101084f41bd011e9cfe3228 commit 497ef4df39aced4f3101084f41bd011e9cfe3228 Author: Daniel Erat <derat@chromium.org> Date: Tue Sep 13 18:09:26 2016 chromeos: Update screenshot notification to "Show in folder" Change the screenshot notification's misleading "Click to view" text to the more-accurate "Show in folder". BUG= 645356 Review-Url: https://codereview.chromium.org/2327863002 Cr-Commit-Position: refs/heads/master@{#417645} (cherry picked from commit 66305867df01ed056de4d0e5edd50dbe25571ea2) Review URL: https://codereview.chromium.org/2333373002 . Cr-Commit-Position: refs/branch-heads/2840@{#333} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/497ef4df39aced4f3101084f41bd011e9cfe3228/ash/ash_chromeos_strings.grdp |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tbuck...@chromium.org
, Sep 9 2016