New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645353 link

Starred by 2 users
Status: Verified
Owner:
est...@chromium.org
Closed: Sep 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary 'Previous' and 'Next' arrow button on find box is enabled without entering text.

Reported by rk...@etouch.net, Sep 9 2016 
Chrome Version: 55.0.2854.2 Revision f75e29a598998d720366ce93737d69236f49e980-refs/branch-heads/2854@{#2}
OS: Windows(7,8,10),Mac(10.10.5,10.11.4) 

What steps will reproduce the problem?
(1) Launch chrome, open NTP and press Ctrl+F 
(2) Observe Previous and Next arrow on find box.

Actual: Unnecessary Previous and Next arrow button on find box is enabled without entering text.

Expected: Previous and Next arrow button on find box should not enabled without entering text.

This is a regression issue, broken in 'M-55', will soon update the other info:

Comment 1 by rk...@etouch.net, Sep 9 2016

Labels: hasbisect OS-Linux
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 55.0.2853.0
Bad Build: 55.0.2854.2

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/81356643cfe6ffe145741fb4b8fef53a3db86a50..2c6e050f06efedae49f77dd91baa016dbd2e8fe9?pretty=fuller&n=1000

Suspecting: r416979

@estade: Please help me to reassign this issue, if your change is not cause for it.
Actual_screenshot.png
5.6 KB View Download

Comment 2 by ranjitkan@chromium.org, Sep 9 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by est...@chromium.org, Sep 13 2016

Labels: OS-Chrome
Status: Started (was: Assigned)
https://codereview.chromium.org/2340503002/
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aabce05f776aa8c56e1d208f9c27423ea90690b

commit 4aabce05f776aa8c56e1d208f9c27423ea90690b
Author: estade <estade@chromium.org>
Date: Wed Sep 14 00:15:04 2016

Fix appearance of disabled VectorIconButtons.

Ironically, removing OnEnabledChanged() fixes this bug. Not calling
through to the parent class's implementation was problematic, but it
turns out that handling changes to the enable state isn't necessary
anyway since that's done with the state parameter of
ImageButton::SetImage().

BUG= 645353 

Review-Url: https://codereview.chromium.org/2340503002
Cr-Commit-Position: refs/heads/master@{#418431}

[modify] https://crrev.com/4aabce05f776aa8c56e1d208f9c27423ea90690b/ui/views/controls/button/vector_icon_button.cc
[modify] https://crrev.com/4aabce05f776aa8c56e1d208f9c27423ea90690b/ui/views/controls/button/vector_icon_button.h

Comment 5 by est...@chromium.org, Sep 14 2016

Status: Fixed (was: Started)

Comment 6 by son...@google.com, Oct 7 2016

Status: Verified (was: Fixed)
Verified on build 8872.0.0
►

Sign in to add a comment