We should disable horizontal overflow during subpage transitions.

This bug is tagged as regression.Which means that the bisects are incorrect or do not have an owner who is actively investigating.
Requesting the reporter to triage and update the behavior in all the latest chrome channels and bisect if needed.Close as WontFix if not reproducible.

MD Settings has not launched yet, so I wouldn't consider this a regression.

@dbeam do you know who can look into this transition?

@dschuyler is this something you could look into?

 Issue 672447  has been merged into this issue.

 Issue 666626  has been merged into this issue.

CL https://codereview.chromium.org/2753943003/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfa14e6ef0b8adc0f56d899f3776fe4b960b8978

commit bfa14e6ef0b8adc0f56d899f3776fe4b960b8978
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Mar 16 21:45:45 2017

[MD settings] hide extra horizontal scrollbar

This CL prevents an unwanted horizontal scrollbar from flashing at the
bottom of the page when transitioning from a sub-page back to the basic
page.

BUG= 645346 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2753943003
Cr-Commit-Position: refs/heads/master@{#457570}

[modify] https://crrev.com/bfa14e6ef0b8adc0f56d899f3776fe4b960b8978/chrome/browser/resources/settings/basic_page/basic_page.html

Unfortunately this fix has caused a small regression. The search bubbles is now getting chopped off when residing at the bottom of the page, see attachment.
Should we revert?

Deleted: search_bubble_chop.png 19.5 KB

	search_bubble_chop.png 19.5 KB View Download

Or perhaps just changing it to overflow-x:hidden, would fix the regression while also fixing the original problem?

Well, overflow-x will potentially add a vertical scroll bar. Instead, let's allow the bubble to draw into the div#overscroll at the bottom of the page.

Are you suggesting to move the div#overscroll inside settings-basic-page? I don't know haw easy that is, but if the overscroll is only necessary for the basic page, it might help. Is the about-page not using it?

Having said that, this bug report was about an unwanted horizontal scrollbar, so overflow-x:hidden seems it could fix the problem and still allow the bubbles to show up outside of their parent in the top/down axis. If that works seems like the smallest fix to me.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/364a557a2bdad974a06b6a74ce46520b26ebba3c

commit 364a557a2bdad974a06b6a74ce46520b26ebba3c
Author: dbeam <dbeam@chromium.org>
Date: Fri Mar 17 18:19:08 2017

Revert of [MD settings] hide extra horizontal scrollbar (patchset #1 id:20001 of https://codereview.chromium.org/2753943003/ )

Reason for revert:
The bug this is fixing
https://bugs.chromium.org/p/chromium/issues/detail?id=645346

Is not as bad as the bug it introduced
https://bugs.chromium.org/p/chromium/issues/detail?id=702496

Original issue's description:
> [MD settings] hide extra horizontal scrollbar
>
> This CL prevents an unwanted horizontal scrollbar from flashing at the
> bottom of the page when transitioning from a sub-page back to the basic
> page.
>
> BUG= 645346 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2753943003
> Cr-Commit-Position: refs/heads/master@{#457570}
> Committed: https://chromium.googlesource.com/chromium/src/+/bfa14e6ef0b8adc0f56d899f3776fe4b960b8978

TBR=dpapad@chromium.org,dschuyler@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 645346 

Review-Url: https://codereview.chromium.org/2756253002
Cr-Commit-Position: refs/heads/master@{#457817}

[modify] https://crrev.com/364a557a2bdad974a06b6a74ce46520b26ebba3c/chrome/browser/resources/settings/basic_page/basic_page.html

dschuyler@: why can't we just do what dpapad@ mentioned about clipping overflow-x only while animating? comment 13

Because it adds a vertical scroll bar mid-page (in addition to the vertical scroll bar on the right edge). dpapad@ and I talked about it in person, sorry I hadn't updated the bug.

New CL at https://codereview.chromium.org/2758863004/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd286e8aba904530c17eeafbd626769822c8a746

commit cd286e8aba904530c17eeafbd626769822c8a746
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Mar 22 20:23:50 2017

[MD settings] hide scrollbar during animation to subpage

This CL will hide overflow during the horizontal swipe page animation.
The overflow will be reset after the animation completes.

BUG= 645346 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2758863004
Cr-Commit-Position: refs/heads/master@{#458859}

[modify] https://crrev.com/cd286e8aba904530c17eeafbd626769822c8a746/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/cd286e8aba904530c17eeafbd626769822c8a746/chrome/browser/resources/settings/settings_page/main_page_behavior.js