New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645335 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clear the custom element reaction queue if upgrading fails

Project Member Reported by kojii@chromium.org, Sep 9 2016

Issue description

Comment 1 by hayato@chromium.org, Sep 12 2016

Owner: kojii@chromium.org

Comment 2 by kojii@chromium.org, Sep 28 2016

Owner: dominicc@chromium.org

Comment 3 by hayato@chromium.org, Oct 12 2016

Components: -Blink>WebComponents Blink>HTML>CustomElements
Status: Started (was: Available)
The web components issue has a nice repro.
 Issue 644602  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5

commit b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5
Author: dominicc <dominicc@chromium.org>
Date: Fri Oct 28 05:04:00 2016

Clear the custom element's reaction queue if upgrade fails.

This is step 7."Finally, ...".2 of
<https://html.spec.whatwg.org/#concept-upgrade-an-element>

BUG= 645335 

Review-Url: https://codereview.chromium.org/2456773002
Cr-Commit-Position: refs/heads/master@{#428288}

[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js
[delete] https://crrev.com/16319599c7ea406d03fbb402f905ccdc472114bd/third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade-expected.txt
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade.html
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
[add] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionTest.cpp
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.cpp
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.h
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueueTest.cpp
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.h
[modify] https://crrev.com/b2bda38bd5c73eeaed5198d7440cf5ddffe3a9c5/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

Status: Fixed (was: Started)

Sign in to add a comment