Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Did some investigation but don't have a good workaround yet.  GWS is doing some magic in the SERP to load content into the AMP switcher in a frame, so it's not clear how to handle this case.

Now AMP pages seem to work quite well in the overlay except for the scrolling up/down issue (issue 653760).  We can special-case AMP pages and force them to promote, but I think that might not be the best solution, even in the near term.  If we promote I don't see an easy way to preserve the ability to switch between sources (left/right scroll in AMP) because this seems to be activate by JS within the frame.  Maybe it would be best to fix the scroll up/down problem? Then instead of special-casing AMP we'll be fixing framed pages in general.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d

commit ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d
Author: donnd <donnd@chromium.org>
Date: Thu Oct 20 21:44:53 2016

[TTS] Promote clicks on AMP carousel to a separate Tab.

An AMP carousel is part of the SRP (Search Result Page) and clicking on one
just does sub-frame loading.  Almost everything works fine except for
issue 653760 which causes the subframe to scroll up but not down.

This change simply promotes clicks on the AMP carousel into a separate Tab.

BUG= 645325 

Review-Url: https://chromiumcodereview.appspot.com/2429913002
Cr-Commit-Position: refs/heads/master@{#426607}

[modify] https://crrev.com/ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

I think we want to merge the fix into M-55, assuming it all works fine over the next few days.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/979bd779542cfda1a5474fb0ad24321ff4487784

commit 979bd779542cfda1a5474fb0ad24321ff4487784
Author: Donn Denman <donnd@google.com>
Date: Mon Oct 24 18:40:02 2016

[TTS] Promote clicks on AMP carousel to a separate Tab.

An AMP carousel is part of the SRP (Search Result Page) and clicking on one
just does sub-frame loading.  Almost everything works fine except for
issue 653760 which causes the subframe to scroll up but not down.

This change simply promotes clicks on the AMP carousel into a separate Tab.

BUG= 645325 

Review-Url: https://chromiumcodereview.appspot.com/2429913002
Cr-Commit-Position: refs/heads/master@{#426607}
(cherry picked from commit ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d)

Review URL: https://codereview.chromium.org/2445803002 .

Cr-Commit-Position: refs/branch-heads/2883@{#246}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/979bd779542cfda1a5474fb0ad24321ff4487784/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/979bd779542cfda1a5474fb0ad24321ff4487784/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/979bd779542cfda1a5474fb0ad24321ff4487784/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

Tested this on 56.0.2900.3. Most links now open in a new tab, but it seems like new window links (_blank) still do not work within AMP carousels that are loaded in a CS overlay. 

Some examples with videos of the behavior are here - http://go/chrome-androidlogs1/6/645325

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/979bd779542cfda1a5474fb0ad24321ff4487784

commit 979bd779542cfda1a5474fb0ad24321ff4487784
Author: Donn Denman <donnd@google.com>
Date: Mon Oct 24 18:40:02 2016

[TTS] Promote clicks on AMP carousel to a separate Tab.

An AMP carousel is part of the SRP (Search Result Page) and clicking on one
just does sub-frame loading.  Almost everything works fine except for
issue 653760 which causes the subframe to scroll up but not down.

This change simply promotes clicks on the AMP carousel into a separate Tab.

BUG= 645325 

Review-Url: https://chromiumcodereview.appspot.com/2429913002
Cr-Commit-Position: refs/heads/master@{#426607}
(cherry picked from commit ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d)

Review URL: https://codereview.chromium.org/2445803002 .

Cr-Commit-Position: refs/branch-heads/2883@{#246}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/979bd779542cfda1a5474fb0ad24321ff4487784/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/979bd779542cfda1a5474fb0ad24321ff4487784/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/979bd779542cfda1a5474fb0ad24321ff4487784/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

[Automated comment] removing mislabelled merge-merged-2840

Looks like there are still minor issues that need to be investigated, maybe due to starting with a blank page or triggering with long-press.

 Issue 694781  has been merged into this issue.

I put this functionality behind a flag for safety, but should have made it a disable flag so it would be auto-enabled.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13dd2cb9a8ed7bf0fc7fd88390f3467f1eada817

commit 13dd2cb9a8ed7bf0fc7fd88390f3467f1eada817
Author: donnd <donnd@chromium.org>
Date: Mon Feb 27 19:24:23 2017

[TTS] Default-enable AMP clicks promote to new tab

A previous CL added special treatment for AMP pages when they
are clicked on in the Contextual Search Overlay.  However the
functionality was behind a flag, which we never enabled.

This changes the AMP case to be behind a default-enabled flag that
will allow us to disable if needed.

BUG= 645325 

Review-Url: https://codereview.chromium.org/2714623002
Cr-Commit-Position: refs/heads/master@{#453291}

[modify] https://crrev.com/13dd2cb9a8ed7bf0fc7fd88390f3467f1eada817/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/13dd2cb9a8ed7bf0fc7fd88390f3467f1eada817/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

This AMP problem was behind a flag, which has just been Finch-enabled.  This should be effectively fixed on 57 (and maybe earlier?) in a few hours with that new config.