Tracing macros for nested instant events: one missing and one duplicate |
|||
Issue descriptionI was looking through the existing nestable trace events in trace_event_common.h [1] and noticed two things I found weird: - There is no TRACE_EVENT_NESTABLE_ASYNC_INSTANT0, that is, a nestable instant async event without any extra arguments. - There are two definitions [2] of TRACE_EVENT_NESTABLE_ASYNC_INSTANT2. [1] https://cs.chromium.org/chromium/src/base/trace_event/common/trace_event_common.h?q=src/base/trace_event/common/trace_event_common.h [2] https://cs.chromium.org/chromium/src/base/trace_event/common/trace_event_common.h?type=cs&q=TRACE_EVENT_NESTABLE_ASYNC_INSTANT2+file:base/trace_event/common/trace_event_common.h&sq=package:chromium
,
Sep 9 2016
CC-ing oysteine@ as git blame tells me he was the last one to touch this code.
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db476ca7de669dd97607ceeabf6f97fbc3201f1e commit db476ca7de669dd97607ceeabf6f97fbc3201f1e Author: carlosk <carlosk@chromium.org> Date: Fri Sep 09 23:10:13 2016 Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. BUG= 645308 Review-Url: https://codereview.chromium.org/2326483004 Cr-Commit-Position: refs/heads/master@{#417753} [modify] https://crrev.com/db476ca7de669dd97607ceeabf6f97fbc3201f1e/base/trace_event/common/trace_event_common.h [modify] https://crrev.com/db476ca7de669dd97607ceeabf6f97fbc3201f1e/third_party/WebKit/Source/platform/TraceEventCommon.h
,
Sep 9 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/4a56318d4c771de50194700083cc1acee0a66fa4 commit 4a56318d4c771de50194700083cc1acee0a66fa4 Author: carlosk <carlosk@chromium.org> Date: Fri Sep 09 23:15:19 2016 Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG= 645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 NOPRESUBMIT=true CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot Review-Url: https://codereview.chromium.org/2321283002 [modify] https://crrev.com/4a56318d4c771de50194700083cc1acee0a66fa4/src/core/SkTraceEventCommon.h
,
Sep 9 2016
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6c565ab62ce68c7c2ed27ecd03f76b917009756 commit a6c565ab62ce68c7c2ed27ecd03f76b917009756 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Sat Sep 10 00:46:30 2016 Roll src/third_party/skia/ 95315f0d6..4a56318d4 (1 commit). https://chromium.googlesource.com/skia.git/+log/95315f0d6f77..4a56318d4c77 $ git log 95315f0d6..4a56318d4 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 carlosk Adds missing and removes duplicate tracing macros. BUG= 645308 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=caryclark@google.com Review-Url: https://codereview.chromium.org/2322243003 Cr-Commit-Position: refs/heads/master@{#417783} [modify] https://crrev.com/a6c565ab62ce68c7c2ed27ecd03f76b917009756/DEPS |
|||
►
Sign in to add a comment |
|||
Comment 1 by carlosk@chromium.org
, Sep 9 2016