New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645303 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[USS] Implement SharedModelTypeProcessor::GetAllNodes for USS

Project Member Reported by gangwu@chromium.org, Sep 8 2016

Issue description

Implement SharedModelTypeProcessor::GetAllNodes for USS, so 
"Sync Node Browser" tab in chrome://sync-internals/ will show USS data.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85949830038a3b8cb2f34d6cd92801c5c4b921f8

commit 85949830038a3b8cb2f34d6cd92801c5c4b921f8
Author: gangwu <gangwu@chromium.org>
Date: Thu Sep 15 00:56:39 2016

[USS] Implement SharedModelTypeProcessor::GetAllNodes for USS

mplement SharedModelTypeProcessor::GetAllNodes for USS, so
"Sync Node Browser" tab in chrome://sync-internals/ will show
USS data.
BTW, modelTypeWorker already ignore the root folder from
server.

BUG= 645303 

Review-Url: https://codereview.chromium.org/2319973003
Cr-Commit-Position: refs/heads/master@{#418735}

[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/api/entity_data.cc
[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/api/entity_data.h
[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/api/model_type_service.h
[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/core/shared_model_type_processor.cc
[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/core/shared_model_type_processor.h
[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/driver/non_blocking_data_type_controller.cc
[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/85949830038a3b8cb2f34d6cd92801c5c4b921f8/components/sync/protocol/proto_value_conversions.h

Comment 2 by gangwu@chromium.org, Sep 16 2016

Status: Fixed (was: Assigned)

Sign in to add a comment