New issue
Advanced search Search tips

Issue 645294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Track user actions when user stops page loading

Project Member Reported by k...@chromium.org, Sep 8 2016

Issue description

Realized we don't have a user action to track if a user stops loading a page (we have reload but not stop). We should add a user action to track when Stop is pressed so we can better understand if users are frequently use "Stop" to prevent any more resources from loading. (which is relevant for page loading improvements)

We currently have MobileToolbarReload (https://cs.chromium.org/search/?q=MobileToolbarReload&sq=package:chromium&type=cs) so it should be a parallel metric since it's the same button.
 
Would you prefer to split out menu stop vs toolbar stop (i.e. phone vs tablet)?

We actually have two reload actions defined, MobileToolbarReload and MobileMenuReload, but we never actually used MobileMenuReload.

If we want to split menu vs toolbar, then we'll do it for both reload and a newly added stop.  Otherwise, we'll just add another one for Stop

Comment 2 by k...@chromium.org, Sep 13 2016

I'm fine merging them as MobileToolbarStop. All other tablet + phone actions are merged so it might be confusing to introduce a split and we can always manually split the actions out by tablet/phone if we want to.
Status: Started (was: Untriaged)
Looked a bit more at this and it seems like most places do track toolbar vs menu separately, so I actually think we should do this here too.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f58462eb176193fd017c8a5e724436cb43d37b5

commit 2f58462eb176193fd017c8a5e724436cb43d37b5
Author: tedchoc <tedchoc@chromium.org>
Date: Mon Sep 19 21:50:21 2016

Add a user action for stop in Android.

This also splits out reload tracking to be from menu (phones)
vs from toolbar (tablets), which is consistent with the other
actions such as download.

BUG= 645294 

Review-Url: https://codereview.chromium.org/2341593003
Cr-Commit-Position: refs/heads/master@{#419577}

[modify] https://crrev.com/2f58462eb176193fd017c8a5e724436cb43d37b5/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/2f58462eb176193fd017c8a5e724436cb43d37b5/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/2f58462eb176193fd017c8a5e724436cb43d37b5/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)

Sign in to add a comment