New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645285 link

Starred by 13 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Fails to open PDF file on Gdrive

Project Member Reported by rookrishna@chromium.org, Sep 8 2016

Issue description

Chrome OS 54.0.2840.13/8743.13.0

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1)open any pdf document in Gdrive
(2)
(3)

Expected Result:Open

Actual Result: unable to open in GDrive

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.


 
Labels: -Type-Bug Type-Bug-Regression
not reproduced on Chrome:53.0.2785.103/ChromeOS:8530.81.0/ARC:3251841 
Having the same issue on 54.0.2840.13 dev (64-bit).

Opening PDFs saved in Drive display like this:
https://drive.google.com/file/d/0By8giC4xerz-WjA0TGpmMTRrZUE/view?usp=sharing

PDFs from weblinks open fine.
I have exactly the same issue since the latest update. I can open PDFs in my Downloads folder, but when I try to open any PDF from my Google Drive I see the same thing as shown in Comment 2.
Cc: weifangsun@chromium.org
 Issue 649190  has been merged into this issue.
We are seeing user complaints on CBC and have verified that we can consistently reproduce this problem.

#CBC-RS/TC-watchlist
Cc: -fukino@chromium.org
Owner: fukino@chromium.org

Comment 7 by nmweb...@gmail.com, Sep 22 2016

Yeah I'm having this issue too, it happens for every Drive stored pdf that I have.
Labels: -ReleaseBlock-Stable ReleaseBlock-Beta

Comment 9 by fukino@chromium.org, Sep 26 2016

Status: Started (was: Untriaged)
I am building a new Beta RC tomorrow, please comment if this bug is feasible to be fixed by then 


I just sent a CL for this issue, so the next beta will not have the fix.
https://codereview.chromium.org/2370223002/


 Issue 650646  has been merged into this issue.
I have shared a file (Simple Instruction.pdf).
You may see a video which reproduce the issue here: https://youtu.be/OFoUZrlPdis
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Labels: Merge-Approved-54
fukino, can you merge the fix CL to M-54 once landed in ToT?
Yes, I'll merge the fix to M54.
The fix https://codereview.chromium.org/2370223002/ has already landed on master, but this issue was not updated for some reason.
The fix was merged to M54.
https://codereview.chromium.org/2378753002
(This issue has yet been updated by the commit, though)
Labels: -Merge-Approved-54 Merge-Merged merge-merged-2840
Status: Fixed (was: Started)
Marking this as Fixed and manually adding Merged labels as bugdroid doesn't update it for some reason.
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbf2420306f6d0a3c85d10a4115ab254b3912162

commit bbf2420306f6d0a3c85d10a4115ab254b3912162
Author: fukino <fukino@chromium.org>
Date: Wed Sep 28 04:34:18 2016

Add externalfile: to PDF extension's object-src.

externalfile:// scheme is used in Chrome OS to open external files (e.g. files in Google Drive) in a browser tab.
After https://codereview.chromium.org/2209113002/, we need to specify it in PDF extension's CSP permissions.

BUG= 645285 
TEST=manually tested the repro steps in the bug description.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2370223002
Cr-Commit-Position: refs/heads/master@{#421447}

[modify] https://crrev.com/bbf2420306f6d0a3c85d10a4115ab254b3912162/chrome/browser/resources/pdf/manifest.json

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4f6f52b011f0f6a7e30b805934a15e04a644ab8

commit b4f6f52b011f0f6a7e30b805934a15e04a644ab8
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Sep 28 15:31:17 2016

Add externalfile: to PDF extension's object-src.

externalfile:// scheme is used in Chrome OS to open external files (e.g. files in Google Drive) in a browser tab.
After https://codereview.chromium.org/2209113002/, we need to specify it in PDF extension's CSP permissions.

BUG= 645285 
TBR=raymes@chromium.org
TEST=manually tested the repro steps in the bug description.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2370223002
Cr-Commit-Position: refs/heads/master@{#421447}
(cherry picked from commit bbf2420306f6d0a3c85d10a4115ab254b3912162)

Review URL: https://codereview.chromium.org/2378753002 .

Cr-Commit-Position: refs/branch-heads/2840@{#561}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b4f6f52b011f0f6a7e30b805934a15e04a644ab8/chrome/browser/resources/pdf/manifest.json

Cc: rookrishna@chromium.org fukino@chromium.org
 Issue 651958  has been merged into this issue.

Comment 22 by f...@noltie.org, Sep 30 2016

I don't know how the bug system works, so this may be expected: the bug still appears in today's dev channel update.

55.0.2869.0 dev (64-bit)
8838.0.0 (Official Build) dev-channel quawks

Status: Verified (was: Fixed)
Verified on Chrome OS  54.0.2840.49/8743.54.0 beta cyan
 Samus 55.0.2878.0/8858.0.0 dev-channel
Cc: tsepez@chromium.org dsinclair@chromium.org
 Issue 652821  has been merged into this issue.
Status: Assigned (was: Verified)
Looks like this is still an issue. 
Status: Verified (was: Assigned)
Issue exists in  55.0.2842.0 but its fixed in version 55.0.2878.0+
Project Member

Comment 27 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4f6f52b011f0f6a7e30b805934a15e04a644ab8

commit b4f6f52b011f0f6a7e30b805934a15e04a644ab8
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Sep 28 15:31:17 2016

Add externalfile: to PDF extension's object-src.

externalfile:// scheme is used in Chrome OS to open external files (e.g. files in Google Drive) in a browser tab.
After https://codereview.chromium.org/2209113002/, we need to specify it in PDF extension's CSP permissions.

BUG= 645285 
TBR=raymes@chromium.org
TEST=manually tested the repro steps in the bug description.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2370223002
Cr-Commit-Position: refs/heads/master@{#421447}
(cherry picked from commit bbf2420306f6d0a3c85d10a4115ab254b3912162)

Review URL: https://codereview.chromium.org/2378753002 .

Cr-Commit-Position: refs/branch-heads/2840@{#561}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b4f6f52b011f0f6a7e30b805934a15e04a644ab8/chrome/browser/resources/pdf/manifest.json

Comment 28 Deleted

Got the same bug on samus
CHROME VERSION
69.0.3486.0 dev
Can't open any pdf in files app except downloads.

Sign in to add a comment