In chrome://md-settings/siteSettings/ in cookies or zoomLevels there are icons at the end of a row to remove the setting. In the mocks, an X icon is used. In the code, a trashcan icon is used. Which is the correct icon to remove a site setting item?
The cross is the right one. The trashcan is not the right one to use. In review.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e45c7b614dab5a62f0425e0752567b59a4035d5 commit 8e45c7b614dab5a62f0425e0752567b59a4035d5 Author: finnur <finnur@chromium.org> Date: Tue Sep 20 09:49:22 2016 Site Settings Desktop: In the Zoom category, use cross icon instead of trashcan. TBR=michaelpg BUG= 645270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2326473004 Cr-Commit-Position: refs/heads/master@{#419709} [modify] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/chrome/browser/resources/settings/people_page/change_picture.html [modify] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/chrome/browser/resources/settings/site_settings/zoom_levels.html [modify] https://crrev.com/8e45c7b614dab5a62f0425e0752567b59a4035d5/ui/webui/resources/cr_elements/icons.html
Comment 1 by finnur@chromium.org
, Sep 9 2016Owner: finnur@chromium.org
Status: Started (was: Assigned)