New issue
Advanced search Search tips

Issue 645261 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Extensions: Get metrics on sync IPCs from the renderer

Project Member Reported by rdevlin....@chromium.org, Sep 8 2016

Issue description

Sync IPCs in extensions code from the renderer are pretty dangerous, because they can execute during content scripts, which can block page load.  We need some metrics on how bad these effects are.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a07f288fe1590b41452214f16d1777706046b9

commit 11a07f288fe1590b41452214f16d1777706046b9
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Fri Sep 09 03:10:19 2016

[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG= 645261 

Review-Url: https://codereview.chromium.org/2316093004
Cr-Commit-Position: refs/heads/master@{#417489}

[modify] https://crrev.com/11a07f288fe1590b41452214f16d1777706046b9/chrome/renderer/extensions/tabs_custom_bindings.cc
[modify] https://crrev.com/11a07f288fe1590b41452214f16d1777706046b9/extensions/renderer/i18n_custom_bindings.cc
[modify] https://crrev.com/11a07f288fe1590b41452214f16d1777706046b9/extensions/renderer/runtime_custom_bindings.cc
[modify] https://crrev.com/11a07f288fe1590b41452214f16d1777706046b9/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-54
Status: Fixed (was: Started)
Requesting merge so we can get a bit more data.

Comment 3 by dimu@chromium.org, Sep 10 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b31379bc1607d5edbb8bcc15256527322849121

commit 5b31379bc1607d5edbb8bcc15256527322849121
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Sep 12 16:45:05 2016

[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG= 645261 

Review-Url: https://codereview.chromium.org/2316093004
Cr-Commit-Position: refs/heads/master@{#417489}
(cherry picked from commit 11a07f288fe1590b41452214f16d1777706046b9)

Review URL: https://codereview.chromium.org/2335713002 .

Cr-Commit-Position: refs/branch-heads/2840@{#302}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/chrome/renderer/extensions/tabs_custom_bindings.cc
[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/extensions/renderer/i18n_custom_bindings.cc
[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/extensions/renderer/runtime_custom_bindings.cc
[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b31379bc1607d5edbb8bcc15256527322849121

commit 5b31379bc1607d5edbb8bcc15256527322849121
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Sep 12 16:45:05 2016

[Extensions] Add metrics for renderer sync IPCs performance

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG= 645261 

Review-Url: https://codereview.chromium.org/2316093004
Cr-Commit-Position: refs/heads/master@{#417489}
(cherry picked from commit 11a07f288fe1590b41452214f16d1777706046b9)

Review URL: https://codereview.chromium.org/2335713002 .

Cr-Commit-Position: refs/branch-heads/2840@{#302}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/chrome/renderer/extensions/tabs_custom_bindings.cc
[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/extensions/renderer/i18n_custom_bindings.cc
[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/extensions/renderer/runtime_custom_bindings.cc
[modify] https://crrev.com/5b31379bc1607d5edbb8bcc15256527322849121/tools/metrics/histograms/histograms.xml

Sign in to add a comment