New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645210 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Maximizing Android app window sometimes does not respect workspace available height

Project Member Reported by osh...@chromium.org, Sep 8 2016

Issue description

chrome side bug for b/31373508.

These two changes has to be merged to m53.

https://codereview.chromium.org/2185773002/
https://codereview.chromium.org/2225523002/
 
Cc: keta...@chromium.org kuscher@chromium.org

Comment 2 by dimu@chromium.org, Sep 9 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.
Labels: -Hotlist-Merge-review -Merge-Review-53 Merge-Approved-53
Cool. Looks like Bernie approved this one. So you are good to go for M53.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5da19c5e8c079e75e47550d04c8dd151219a4326

commit 5da19c5e8c079e75e47550d04c8dd151219a4326
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Sep 13 00:09:30 2016

Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG= 631557 , 645210 
Committed: https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212
Cr-Commit-Position: refs/heads/master@{#408507}

Review URL: https://codereview.chromium.org/2335963002 .

Cr-Commit-Position: refs/branch-heads/2785@{#879}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/common/shell_observer.h
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/common/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/common/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/display/display_manager.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/shell.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/wm/window_modality_controller_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/components/exo/wayland/server.cc

Comment 6 by osh...@chromium.org, Sep 13 2016

Status: Fixed (was: Started)
2nd CL is merged in : https://codereview.chromium.org/2338603002/

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment