New issue
Advanced search Search tips

Issue 645202 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Feature

Blocked on:
issue 644262



Sign in to add a comment

Migrate Blimp Linux Client to 0.6 APIs

Project Member Reported by dtrainor@chromium.org, Sep 8 2016

Issue description

Currently the Linux client is using the old 0.5 class structure for a Blimp client.  This needs to be ported over to the new 0.6 files.  This involves something like:

- Remove BlimpClientSessionLinux and pull display/event handling out.
- Build a BlimpClientContext.
- Add/use ConnectWithAssignment (method also being added in an integration test).
- Build a BlimpContents.

This might also require using a dummy IMEDelegate that auto-hides when it gets a ShowIME request.  This might also be added during integration tests as well though.

 
As an update, might not need to use ConnectWithAssignment since the command line arguments are processed inside BlimpClientContext.
Blockedon: 644262
Cc: -mlliu@chromium.org
Owner: w...@chromium.org
Wez can you triage?  Marking this as blocked on the integration test.  That should hopefully land this week.

Comment 3 by w...@chromium.org, Sep 8 2016

Owner: steimel@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Tommy, since he has been working with the Linux Client recently.

Tommy, please take a look at the work breakdown in the bug description and let me know if you have questions!
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01

commit d890645241cfa41fe40e22a5cdf5cd9d6cef4f01
Author: steimel <steimel@chromium.org>
Date: Thu Sep 29 16:59:47 2016

Migrating the Linux Blimp client away from using the deprecated BlimpClientSession and towards using BlimpClientContext.

For this CL, we now create a BlimpClientContext and create a BlimpContents from that to send to the display manager, which replaces the individual features being sent before (e.g. TabControlFeature).

blimp_main now handles some things that were being handled in the BlimpClientSession (e.g. creating a display manager and an IO thread)

BUG= 645202 

Review-Url: https://codereview.chromium.org/2363153002
Cr-Commit-Position: refs/heads/master@{#421851}

[modify] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/BUILD.gn
[add] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/app/linux/blimp_client_context_delegate_linux.cc
[add] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/app/linux/blimp_client_context_delegate_linux.h
[modify] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/app/linux/blimp_display_manager.h
[add] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/app/linux/blimp_display_manager_delegate_main.cc
[add] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/app/linux/blimp_display_manager_delegate_main.h
[modify] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/support/BUILD.gn
[add] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/support/session/BUILD.gn
[add] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/support/session/blimp_default_identity_provider.cc
[add] https://crrev.com/d890645241cfa41fe40e22a5cdf5cd9d6cef4f01/blimp/client/support/session/blimp_default_identity_provider.h

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment