Ripple effect appears on mouseup, not mousedown.
Reported by
jleedev@gmail.com,
Sep 8 2016
|
|||
Issue descriptionExpect behavior, as in md-history: - Open the sidebar and press the mouse down on an item. The ripple appears on mouse down. Actual behavior in md-settings: - Open the sidebar and press the mouse down on an item. The ripple doesn't appear until mouse up. This is barely visible, and is inconsistent.
,
Sep 15 2016
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9adedb441e090b88388e0f61333163967bc0264 commit b9adedb441e090b88388e0f61333163967bc0264 Author: dschuyler <dschuyler@chromium.org> Date: Fri Sep 16 23:46:43 2016 [MD settings] ripple on mouse down in side nav This CL changes the ripple to trigger on mouse down rather than mouse up. This better matches other uses of paper-ripple. BUG= 645190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2341593002 Cr-Commit-Position: refs/heads/master@{#419331} [modify] https://crrev.com/b9adedb441e090b88388e0f61333163967bc0264/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/b9adedb441e090b88388e0f61333163967bc0264/chrome/browser/resources/settings/settings_menu/settings_menu.js
,
Sep 17 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tbuck...@chromium.org
, Sep 13 2016Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)