New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645186 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security



Sign in to add a comment

Memcpy-param-overlap in CCodec_ProgressiveDecoder::JpegReadMoreData

Project Member Reported by ClusterFuzz, Sep 8 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4775874488696832

Fuzzer: libfuzzer_pdf_codec_jpeg_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Memcpy-param-overlap
Crash Address: [0x621000007900,0x6210000086e0) and [0x621000007b20, 0x621000008900)
Crash State:
  CCodec_ProgressiveDecoder::JpegReadMoreData
  CCodec_ProgressiveDecoder::ContinueDecode
  Fuzz
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=410288:412598

Minimized Testcase (8.99 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97_8ywfv4LVH_Ev4bYP2CkjhhPFByEM0aXc_KFZQ-NJkFFKg_XOsMITq5TKhIymvAEXBJalDCA8nvFc-fT_y6A6B9fGyqsCpVtexOglvmpoNIpiNBjpXU2BVYaN1l7uJib7PFayo43ayhdjLgyWw91cNBYvsQ?testcase_id=4775874488696832

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Labels: -OS-Mac OS-All
Owner: hong_zh...@foxitsoftware.com
Status: Available (was: Untriaged)
hong_zhang: Can you take a look at this?
Components: Internals>Plugins>PDF
@mbarbella Yes I will.
Do we just need to switch to memmove() ?
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 9 2016

Labels: M-55
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 9 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 9 2016

Labels: Pri-1
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 9 2016

Status: Assigned (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee727c8ac26512c3f6fe852fdefb00186909a89

commit dee727c8ac26512c3f6fe852fdefb00186909a89
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Mon Sep 12 19:25:29 2016

Roll src/third_party/pdfium/ 1c62054a4..0b022056c (2 commits).

https://pdfium.googlesource.com/pdfium.git/+log/1c62054a42cf..0b022056c74c

$ git log 1c62054a4..0b022056c --date=short --no-merges --format='%ad %ae %s'
2016-09-12 tracy_jiang change memcpy to memmove for potential nearby addresses
2016-09-12 hong_zhang fix some uninitialized variables

BUG= 645186 , 627399 

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2332793003
Cr-Commit-Position: refs/heads/master@{#418000}

[modify] https://crrev.com/dee727c8ac26512c3f6fe852fdefb00186909a89/DEPS

Project Member

Comment 10 by ClusterFuzz, Sep 13 2016

ClusterFuzz has detected this issue as fixed in range 417990:418014.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4775874488696832

Fuzzer: libfuzzer_pdf_codec_jpeg_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Memcpy-param-overlap
Crash Address: [0x621000007900,0x6210000086e0) and [0x621000007b20, 0x621000008900)
Crash State:
  CCodec_ProgressiveDecoder::JpegReadMoreData
  CCodec_ProgressiveDecoder::ContinueDecode
  Fuzz
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=410288:412598
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=417990:418014

Minimized Testcase (8.99 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97_8ywfv4LVH_Ev4bYP2CkjhhPFByEM0aXc_KFZQ-NJkFFKg_XOsMITq5TKhIymvAEXBJalDCA8nvFc-fT_y6A6B9fGyqsCpVtexOglvmpoNIpiNBjpXU2BVYaN1l7uJib7PFayo43ayhdjLgyWw91cNBYvsQ?testcase_id=4775874488696832

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Sep 13 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 13 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 20 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment