New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645182 link

Starred by 1 user
Status: Fixed
Owner:
█ cco3@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
█ animohan@chromium.org
█ scottj@chromium.org
█ mmo...@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Physical Web background scan not being started

Project Member Reported by cco3@chromium.org, Sep 8 2016 
In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.

Bug introduced here:
https://codereview.chromium.org/2176373007/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java

Fixed here:
https://codereview.chromium.org/2316413002/
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0

commit 8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0
Author: cco3 <cco3@chromium.org>
Date: Thu Sep 08 21:55:48 2016

Run Physical Web background subscription

In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.  This change
actually performs the subscription.

BUG= 623638 , 645182 

Review-Url: https://codereview.chromium.org/2316413002
Cr-Commit-Position: refs/heads/master@{#417410}

[modify] https://crrev.com/8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f0fbae251307c486c4df305e68798c002842ca0

commit 9f0fbae251307c486c4df305e68798c002842ca0
Author: cco3 <cco3@chromium.org>
Date: Fri Sep 09 21:05:41 2016

Run Physical Web background subscription

In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.  This change
actually performs the subscription.

BUG= 623638 , 645182 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2316413002
Cr-Commit-Position: refs/heads/master@{#417410}
(cherry picked from commit 8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0)

Review-Url: https://codereview.chromium.org/2328803002
Cr-Commit-Position: refs/branch-heads/2840@{#282}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/9f0fbae251307c486c4df305e68798c002842ca0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java

Comment 3 by cco3@chromium.org, Sep 12 2016

Labels: -M-44 M-54
Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f0fbae251307c486c4df305e68798c002842ca0

commit 9f0fbae251307c486c4df305e68798c002842ca0
Author: cco3 <cco3@chromium.org>
Date: Fri Sep 09 21:05:41 2016

Run Physical Web background subscription

In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.  This change
actually performs the subscription.

BUG= 623638 , 645182 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2316413002
Cr-Commit-Position: refs/heads/master@{#417410}
(cherry picked from commit 8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0)

Review-Url: https://codereview.chromium.org/2328803002
Cr-Commit-Position: refs/branch-heads/2840@{#282}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/9f0fbae251307c486c4df305e68798c002842ca0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
►

Sign in to add a comment