New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645165 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

getElementsByTagName should take a qualified name

Project Member Reported by rbyers@chromium.org, Sep 8 2016

Issue description

DOM spec has changed for this:
https://github.com/whatwg/dom/issues/143
https://dom.spec.whatwg.org/#dom-document-getelementsbytagname

WebKit nightly (https://trac.webkit.org/changeset/204441) and Firefox match the spec, we should consider trying to change too.
 

Comment 1 by tkent@chromium.org, Sep 9 2016

Status: Available (was: Untriaged)

Comment 2 by tkent@chromium.org, Mar 3 2017

Labels: Needs-BlinkIntent

Comment 3 by dch...@gmail.com, Mar 28 2017

This behavior has just shipped in Safari 10.1. It would be great to align Chrome with Firefox/Safari and the spec for interoperability.

Comment 4 by tkent@chromium.org, Apr 16 2017

Cc: tkent@chromium.org
Labels: -Type-Bug -Needs-BlinkIntent Hotlist-GoodFirstBug Type-Feature
The intent was approved.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jBph1e0CekY

I don't have a plan to implement this soon.  Contribution is welcome.

Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, May 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5025bccfe31b6c49a1e868d58568a89c75b3f338

commit 5025bccfe31b6c49a1e868d58568a89c75b3f338
Author: shanmuga.m <shanmuga.m@samsung.com>
Date: Sun May 14 23:10:24 2017

getElementsByTagName() should take a qualifiedName in parameter

getElementsByTagName() should take a qualifiedName in parameter, not a
localName, according to the latest DOM specification:
https://dom.spec.whatwg.org/#dom-document-getelementsbytagname
https://dom.spec.whatwg.org/#concept-getelementsbytagname

Webkit patch:
https://trac.webkit.org/changeset/204441/

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jBph1e0CekY

BUG= 645165 

Review-Url: https://codereview.chromium.org/2868823002
Cr-Commit-Position: refs/heads/master@{#471643}

[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-getElementsByTagName-expected.txt
[delete] https://crrev.com/3639139a6216af6f66840f8348622d45ba06d5b9/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-getElementsByTagName-xhtml-expected.txt
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Element-getElementsByTagName-expected.txt
[delete] https://crrev.com/3639139a6216af6f66840f8348622d45ba06d5b9/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/case-expected.txt
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/dom/ContainerNode.h
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/dom/NodeListsNodeData.cpp
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/dom/NodeListsNodeData.h
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/dom/TagCollection.cpp
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/dom/TagCollection.h
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/html/CollectionType.h
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/html/HTMLTagCollection.cpp
[modify] https://crrev.com/5025bccfe31b6c49a1e868d58568a89c75b3f338/third_party/WebKit/Source/core/html/HTMLTagCollection.h

Comment 7 by tkent@chromium.org, May 14 2017

Labels: M-60
Status: Fixed (was: Assigned)

Comment 8 by tkent@chromium.org, Jul 11 2017

Cc: ranjitkan@chromium.org shanmug...@samsung.com
 Issue 738372  has been merged into this issue.

Sign in to add a comment