New issue
Advanced search Search tips

Issue 645161 link

Starred by 1 user
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Android: TalkBack thinks editable text control has text when it's just a placeholder

Project Member Reported by dmazz...@chromium.org, Sep 8 2016 
To repro, focus an editable text field that has a placeholder, like:

data:text/html,<input placeholder="Type here">

TalkBack exposes cursor movement commands even though the text is actually blank and only the placeholder is showing.

See related bug: b/28980227
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f43b118065d29486b240bc3546ac566c01959ebb

commit f43b118065d29486b240bc3546ac566c01959ebb
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Oct 10 20:13:52 2016

Don't expose Android set selection accessibility action for empty text fields

We shouldn't be exposing the SET_SELECTION action on text fields that
only have placeholder text, that's how TalkBack distinguishes between
real text and placeholder text.

Also fixes bug where CUT, COPY, and PASTE actions were set in the
base class but not the Lollipop subclass.

BUG= 645161 

Review-Url: https://codereview.chromium.org/2319903003
Cr-Commit-Position: refs/heads/master@{#424217}

[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/browser/accessibility/accessibility_tree_formatter_android.cc
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/aria/aria-invalid-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/aria/aria-readonly-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/aria/aria-textbox-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/aria/aria-textbox-with-selection-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-datetime-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-email-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-password-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-search-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-tel-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-text-expected-mac.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-text-expected-win.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-text-name-calc-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-text-value-changed-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-text-value-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-text-with-selection-expected-android.txt
[modify] https://crrev.com/f43b118065d29486b240bc3546ac566c01959ebb/content/test/data/accessibility/html/input-url-expected-android.txt

Comment 2 by dmazz...@chromium.org, Oct 13 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment