New issue
Advanced search Search tips

Issue 645155 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[Offline Pages] Add Coordinator event logs for dropped requests (to help with retry count visibility)

Project Member Reported by dougarnett@chromium.org, Sep 8 2016

Issue description

Consider logging the BackgroundSavePageStatus when Coordinator or Picker decides to remove a request.
 
Components: UI>Browser>Offline
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32febbf7cb75de2bcbd277cdbc994749ce9e6d48

commit 32febbf7cb75de2bcbd277cdbc994749ce9e6d48
Author: dougarnett <dougarnett@chromium.org>
Date: Mon Sep 12 21:49:56 2016

[Offline Pages] Adds event logs for requests dropped due to number of start or complete attempts.

BUG= 645155 

Review-Url: https://codereview.chromium.org/2324493005
Cr-Commit-Position: refs/heads/master@{#418064}

[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/offliner.h
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_coordinator_event_logger.cc
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_coordinator_event_logger.h
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_notifier.h
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_picker.cc
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_picker.h
[modify] https://crrev.com/32febbf7cb75de2bcbd277cdbc994749ce9e6d48/components/offline_pages/background/request_picker_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment