New issue
Advanced search Search tips

Issue 645140 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Content settings icons have no tooltip in MD

Project Member Reported by phistuck@gmail.com, Sep 8 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 Safari/537.36

Steps to reproduce the problem:
1. Block some websites from storing cookies.
2. Go to that website.
3. Hover over the blocked cookies icon in the omnibox.

What is the expected behavior?
A tooltip that reads, "This page was prevented from setting cookies.", is shown.

As stated in -
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?q=IDS_BLOCKED_COOKIES_TITLE&sq=package:chromium&dr=C&l=2336
Used in -
https://cs.chromium.org/chromium/src/chrome/browser/ui/content_settings/content_setting_image_model.cc?cl=GROK&gsn=GetImageDetails&l=110

What went wrong?
No tooltip.

Did this work before? Yes Chrome 52, apparently

Chrome version: 53.0.2785.101, 55.0.2853.0  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

This works in the non-material-design top Chrome, even in the canary.
 
Components: -UI UI>Browser>Omnibox
Labels: -Type-Bug -Pri-2 Hotlist-Accessibility Proj-MaterialDesign-NativeUI Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Owner: est...@chromium.org
Summary: Content settings icons have no tooltip in MD (was: The blocked cookies icon in the omnibox does not have a tooltip)
If this was lost in MD, that's probably unintentional.

I think Evan was the person refactoring the content settings icon code for MD?
Are you sure that it worked in m52 or is that conjecture? I found the fix but it looks to me like it's been broken since 2013 or so.
Status: Started (was: Untriaged)
Works for me in M-52.
M-52.png
21.3 KB View Download

Comment 6 by phistuck@gmail.com, Sep 8 2016

I did not actually check Chrome 52, I just disabled the material design in Chrome 55 canary and it worked. Since Chrome 53 brought material design to everyone (or most of the users?), I let myself state Chrome 52 as working, even though I did not really try it. Good enough, though, right? :)
Then how it broke may remain a mystery not worth solving. The fix is incoming one way or another.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37

commit 31c20ef1d76caf6e6f1a5489c30ef5136d56cf37
Author: estade <estade@chromium.org>
Date: Fri Sep 09 19:35:47 2016

Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip. Set the tooltip on the ContentSettingImageView instead.

BUG= 645140 

Review-Url: https://codereview.chromium.org/2323973002
Cr-Commit-Position: refs/heads/master@{#417670}

[modify] https://crrev.com/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37/chrome/browser/ui/views/location_bar/content_setting_image_view.h

Comment 9 by phistuck@gmail.com, Sep 10 2016

Looks like the mixed content icon also does not have a tooltip (the one that opens a bubble about scripts from unauthenticated sources and lets you "Load unsafe scripts"). Do you want me to create an issue for it (can you just make sure all of the icons have tooltips?)?

Comment 10 by phistuck@gmail.com, Sep 10 2016

As a tangent, the icons are so small that their meaning are entirely unclear to me. I would not have to look for the tooltip if the icons were recognizable.
I think that little red-and-white x is covering a lot of the already-small icon and makes it unclear, but the problem may be present even without it.
Are you saying it doesn't have a tooltip even with the patch that landed above? i.e. you can now see one for cookies but not mixed content? The fix should apply to all content settings icons.

Comment 12 by phistuck@gmail.com, Sep 10 2016

I have not tested your change yet (does the latest canary have it?). However, I am not sure the mixed content icon is related to content settings (it is not configurable by the content settings section of the settings).
Cc: melandory@chromium.org
 Issue 649028  has been merged into this issue.

Sign in to add a comment