New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645136 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Security: heap-buffer-overflow on ProcessTwoPixelPairs

Reported by ntrip...@gmail.com, Sep 8 2016

Issue description

read heap buffer overflow, i attach the asan log. didnt take a look or reversed just taked from the fuzzer and sended here

VERSION
Chrome Version: 53.0.2785.92 + stable
Operating System: Linux

REPRODUCTION CASE

attached 

 
asan_b.txt
17.1 KB View Download
poc.html
984 bytes View Download
Project Member

Comment 1 by ClusterFuzz, Sep 8 2016

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://cluster-fuzz.appspot.com/testcase?key=5722347892113408
Project Member

Comment 2 by ClusterFuzz, Sep 8 2016

Labels: Security_Severity-Medium
Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5722347892113408

Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x7fc9a4ad2d98
Crash State:
  S32_opaque_D32_filter_DX_SSSE3
  BitmapProcShaderContext::shadeSpan
  SkColorFilterShader::FilterShaderContext::shadeSpan
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=268656:269696

Minimized Testcase (0.70 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97yygVZApZmTGyNkI3i1jaDi_aDnSoeukYrmaaovgo1iUt7RlUc22vUhaLrmXj9dzhyRg6zkNSCl629VG_EslEfBUNW7Ijfg1jse8h2gSYbecqsSmOj1htG0hwj9UkGNswI7PVBk1Yi2V191A8rC0qoBZGAxA?testcase_id=5722347892113408
<head>
<script>
var x = {};
function crash() {
    x[648] = document.createElementNS('http://www.w3.org/1999/xhtml', 'canvas');
    x[855] = x[648].getContext('2d', { alpha: true });
'http://www.w3.org/1999/xhtml', 'canvas';
    x[1610] = document.createElementNS('http://www.w3.org/1999/xhtml', 'canvas');
    x[2330] = x[1610].getContext('2d', { willReadFrequently: true, alpha: false });
    x[1610].width = 9171;
'2d', { willReadFrequently: false, alpha: true };
    x[2330].strokeRect(0.3649263580713715, 128, 8, 32);
    x[855].shadowBlur = 512;
    x[855].shadowColor = "red";
    x[855].drawImage(x[1610], 0.4827066851972385, 8, 0.8359630000395614, 0.10588275643668202);
}
</script>
<body onload="crash();"</html>


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

A recommended severity was added to this bug. Please change the severity if it is inaccurate.

Comment 3 by wfh@chromium.org, Sep 9 2016

Labels: Security_Impact-Stable
Owner: mtklein@chromium.org
Status: Assigned (was: Unconfirmed)
seems this has been there for a while

mtklein -> can you take a look at this issue?

Comment 4 by wfh@chromium.org, Sep 9 2016

Components: Internals>Skia
Labels: Pri-1

Comment 5 by ntrip...@gmail.com, Sep 9 2016

Tomorrow I will take a look too
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 9 2016

Labels: M-54
Labels: OS-Linux
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 23 2016

mtklein: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 8 2016

mtklein: Uh oh! This issue still open and hasn't been updated in the last 29 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: caryclark@chromium.org reed@chromium.org
mtklein@, have you had a chance to take a look? I re-uploaded the testcase to check if that's still reproducible.

CC'ing more skia folks.
Project Member

Comment 11 by ClusterFuzz, Oct 11 2016

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://cluster-fuzz.appspot.com/testcase?key=4595428811341824
Labels: reward-topanel
I have not yet looked.
I've started looking at this.

S32_opaque_D32_filter_DX_SSSE3 is rather complex.  S32_opaque_D32_filter_DX_SSE2 is still not exactly straightforward, but a lot simpler to follow.  I took a look at both, paying particular attention to the loads and stores, and nothing jumped out at me as buggy looking.  I'm more confident about the _SSE2 version than the _SSSE3 version.

I'll see which of the _SSSE3 and _SSE2 options I can get to repro this.
Project Member

Comment 15 by sheriffbot@chromium.org, Dec 2 2016

Labels: -M-54 M-55
Status: WontFix (was: Assigned)
I'm afraid I haven't been able to reproduce this with ASAN builds of content_shell or chrome.
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 13 2016

Labels: -reward-topanel reward-ineligible
Project Member

Comment 18 by sheriffbot@chromium.org, Mar 21 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment