Clean up Assignment Creation in BlimpClientContextImpl |
||||
Issue descriptionWe have a lot of asynchronous calls and state machine logic in BlimpClientContextImpl around getting an Assignment. Ideally we'd pull this out to an AssignmentFetcher or something that does: 1. Try to trigger the IdentitySource to connect. 2. Call into the AssignmentSource. 3. Call back into BlimpClientContext with ConnectWithAssignment(Assignment). It would be great to have BlimpClientContext::Connect() just call assignment_fetcher_->Fetch() or something :).
,
Oct 19 2016
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52420812ebff2adf3788d464e51cabeb246a5717 commit 52420812ebff2adf3788d464e51cabeb246a5717 Author: lethalantidote <lethalantidote@chromium.org> Date: Tue Oct 25 21:36:52 2016 Clean up Assignment Create in BlimpClientContextImpl. This is the intial commit for cleaning up BlimpClientContextImpl, pulling out assignment creation code into AssignmentFetcher. BUG= 645129 Review-Url: https://codereview.chromium.org/2406403003 Cr-Commit-Position: refs/heads/master@{#427486} [modify] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/context/BUILD.gn [add] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/context/assignment_fetcher.cc [add] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/context/assignment_fetcher.h [modify] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/context/blimp_client_context_impl.cc [modify] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/context/blimp_client_context_impl.h [modify] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/session/identity_source.cc [modify] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/session/identity_source.h [modify] https://crrev.com/52420812ebff2adf3788d464e51cabeb246a5717/blimp/client/core/session/identity_source_unittest.cc
,
Oct 26 2016
,
Dec 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lethalantidote@chromium.org
, Oct 10 2016Status: Assigned (was: Untriaged)