New issue
Advanced search Search tips

Issue 645108 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Text selection can't scroll down in maximized window

Project Member Reported by tdres...@chromium.org, Sep 8 2016

Issue description

To repro:
- Open maximized window on Linux or Mac (haven't tested Windows)
- Start text selection, and move the cursor to the bottom of the screen.

The page should scroll down, but doesn't.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7026e2d381d6f3f8d46394bf173b92c2826a5d5

commit b7026e2d381d6f3f8d46394bf173b92c2826a5d5
Author: sunyunjia <sunyunjia@chromium.org>
Date: Tue Sep 20 02:29:45 2016

Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area (within a certain distance to the border and inside).

BUG= 645108 

Review-Url: https://codereview.chromium.org/2355643002
Cr-Commit-Position: refs/heads/master@{#419654}

[add] https://crrev.com/b7026e2d381d6f3f8d46394bf173b92c2826a5d5/third_party/WebKit/LayoutTests/fast/events/selection-autoscroll-borderbelt.html
[modify] https://crrev.com/b7026e2d381d6f3f8d46394bf173b92c2826a5d5/third_party/WebKit/Source/core/page/AutoscrollController.cpp

Owner: sunyunjia@chromium.org
Status: Fixed (was: Started)
Labels: Hotlist-Input-Dev

Comment 5 by tkent@chromium.org, Oct 12 2016

Components: -Blink>TextSelection Blink>Editing>Selection

Comment 6 by bokan@chromium.org, Nov 3 2016

 Issue 661114  has been merged into this issue.
Cc: bokan@chromium.org yosin@chromium.org
 Issue 365157  has been merged into this issue.

Sign in to add a comment