New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645087 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 13
Cc:
ajha@chromium.org
█ bruthig@chromium.org
█ groby@chromium.org
pkasting@chromium.org
varkha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

ripple remains on extensions in the browser action area even after opening/closing the context Menu

Project Member Reported by ajha@chromium.org, Sep 8 2016 
Version: 54.0.2840.16
OS: Linux Ubuntu 14.04, Windows-10

What steps will reproduce the problem?
(1) Launch chrome and add few extension so that these extensions show up in the browser action area.
(2) Left click on the extension and press Menu key from the keyboard.
(3) Close the opened context menu by ESC and observe the Focus.

What is the expected output?
> Extension should not be focused after context menu is closed or page is refreshed.

What do you see instead?
> Extension is still focused and focus doesnot disappear even after page refresh.

Please use labels and text to provide additional information.
> Attached is the actual and expected behavior of the same.
> This is a regression issue broken in M-53.


Last good build: 53.0.2750.0
First bad build: 53.0.2751.0

Changelog: https://chromium.googlesource.com/chromium/src/+log/eaba8a8909776cea5e0dc5203ec2d04316b3a5d5..acdd8952437b03d69151e183134e5268a33a1ea3

Suspecting: https://codereview.chromium.org/2012313002

Evan@: Could you please take a look at this.

Thank you!
MenuKeyFocus_Expected.mp4
287 KB View Download
MenuKeyFocus_Actual.mp4
574 KB View Download

Comment 1 by ligim...@chromium.org, Sep 8 2016

Labels: -M-55 M-54 ReleaseBlock-Stable
Can we get this fixed before M54 hits stable.

Comment 2 by est...@chromium.org, Sep 8 2016

Cc: bruthig@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: ajha@chromium.org
Summary: ripple remains on extensions in the browser action area even after opening/closing the context Menu (was: Regression: Focus remains on extensions in the browser action area even after opening/closing the context Menu )
a) I don't think the changelog is correct, because none of the changes (my own included) look at all relevant
b) it's a crazy corner case and not worth RBS

re-assigning to reporter to verify regression range.

Comment 3 by bruthig@chromium.org, Sep 8 2016

Cc: varkha@chromium.org
Owner: bruthig@chromium.org
Assigning myself and adding Valery as he added the ripple to the extension buttons originally. I am able to repro this on a Linux build number 53.0.2785.92.

I will look more at this tomorrow, but I'd be surprised if this was caused by a recent CL.

Comment 4 by bruthig@chromium.org, Sep 8 2016

Labels: Proj-MaterialDesign-NativeUI
FTR I am also seeing this on other MenuButton surfaces (e.g. Bookmark folder buttons.)

Comment 5 by varkha@chromium.org, Sep 9 2016

Components: -Blink>Focus -Platform>Extensions UI>Browser>Toolbar
Labels: -M-54 M-55
I think it is only worth merging if the fix is trivial. Otherwise I would target M-55.

Comment 6 by bruthig@chromium.org, Aug 11 2017

Cc: pkasting@chromium.org
Owner: rpop@chromium.org
Status: Available (was: Assigned)
Handing off to Rachel to triage.

Comment 7 by rpop@chromium.org, Oct 3 2017

Cc: groby@chromium.org
Owner: ----

Comment 8 by robliao@chromium.org, Sep 13

Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 9 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment