New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

We need to sync device_management_backend.proto with server side on a regular basis.

Project Member Reported by tnagel@chromium.org, Sep 8 2016

Issue description

Probably it would make sense to incorporate syncing of device_management_backend.proto into the script that semi-automatically syncs chrome_settings.proto and chrome_device_settings.proto.
 
Components: Enterprise
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b72e27717e3713ae3ca673f0afbfd99aa951c28

commit 9b72e27717e3713ae3ca673f0afbfd99aa951c28
Author: tnagel <tnagel@chromium.org>
Date: Tue Sep 27 15:10:22 2016

Move device_management_backend.proto closer to the server version.

No functional change, just updating comments and moving a block around.

BUG= 645078 

Review-Url: https://codereview.chromium.org/2320873004
Cr-Commit-Position: refs/heads/master@{#421213}

[modify] https://crrev.com/9b72e27717e3713ae3ca673f0afbfd99aa951c28/components/policy/proto/device_management_backend.proto

Comment 3 by tnagel@chromium.org, Oct 12 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f15e4cc046f62b1332076dc834e201d697ecc58

commit 1f15e4cc046f62b1332076dc834e201d697ecc58
Author: tnagel <tnagel@chromium.org>
Date: Thu Oct 13 11:43:43 2016

Partial sync of device_management_backened.proto with server version.

Client and server are still not fully aligned, but getting closer...

BUG= 645078 

Review-Url: https://codereview.chromium.org/2407163005
Cr-Commit-Position: refs/heads/master@{#425003}

[modify] https://crrev.com/1f15e4cc046f62b1332076dc834e201d697ecc58/components/policy/core/common/cloud/cloud_policy_client.cc
[modify] https://crrev.com/1f15e4cc046f62b1332076dc834e201d697ecc58/components/policy/proto/device_management_backend.proto

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c89efcfde96aafbc938d2ac4309d466a0f0fb31c

commit c89efcfde96aafbc938d2ac4309d466a0f0fb31c
Author: tnagel <tnagel@chromium.org>
Date: Thu Oct 20 09:16:10 2016

Harmonize the style of obsolete protos to match that of chrome_device_settings.proto.

Preparation for sync with server.

BUG= 645078 

Review-Url: https://chromiumcodereview.appspot.com/2424983002
Cr-Commit-Position: refs/heads/master@{#426434}

[modify] https://crrev.com/c89efcfde96aafbc938d2ac4309d466a0f0fb31c/components/policy/proto/device_management_backend.proto

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a1580424d6de98575f9015f3ef3585a12c8d2dc

commit 9a1580424d6de98575f9015f3ef3585a12c8d2dc
Author: tnagel <tnagel@chromium.org>
Date: Thu Oct 20 17:45:59 2016

Sync more DMServer proto comments to the client.

Also replace mentionings of the deprecated platformKeysPrivate by
platformKeys.  Comments only, no functional changes.

BUG= 645078 

Review-Url: https://chromiumcodereview.appspot.com/2424003003
Cr-Commit-Position: refs/heads/master@{#426523}

[modify] https://crrev.com/9a1580424d6de98575f9015f3ef3585a12c8d2dc/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/9a1580424d6de98575f9015f3ef3585a12c8d2dc/components/policy/proto/device_management_backend.proto
[modify] https://crrev.com/9a1580424d6de98575f9015f3ef3585a12c8d2dc/components/policy/resources/policy_templates.json

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78ff9da2c0349d700b15428c6da567c61b894f1a

commit 78ff9da2c0349d700b15428c6da567c61b894f1a
Author: tnagel <tnagel@chromium.org>
Date: Wed Nov 02 12:39:01 2016

Match server version of DM API proto.

Some fields are renamed:
* new_public_key_verification_signature
  --> new_public_key_verification_signature_deprecated
* PolicyPublicKeyAndDomain
  --> DEPRECATEDPolicyPublicKeyAndDomain
* RemoteCommand.unique_id
  --> RemoteCommand.command_id

BUG= 645078 

Review-Url: https://codereview.chromium.org/2453993004
Cr-Commit-Position: refs/heads/master@{#429257}

[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/chrome/browser/policy/test/policy_testserver.py
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/cloud/cloud_policy_validator.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/cloud/policy_builder.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/cloud/user_cloud_policy_store.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/remote_commands/remote_commands_queue_unittest.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/remote_commands/remote_commands_service.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/core/common/remote_commands/testing_remote_commands_server.cc
[modify] https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a/components/policy/proto/device_management_backend.proto

Status: Fixed (was: Started)

Sign in to add a comment