New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 645076 link

Starred by 2 users
Status: Verified
Owner:
varkha@chromium.org
Closed: Sep 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted border of overview window is seen on pinned apps in shelf

Project Member Reported by sc00335...@techmahindra.com, Sep 8 2016 
Version: 55.0.2852.0/8780.0.0 dev channel auron_paine,Wolf,Falco
OS: Chrome OS

What steps will reproduce the problem?
(1) Sign in to user >> Pin 8-10 apps to shelf >> Make shelf position to left/right
(2) Now open any window >> Switch to overview mode using []|| button >> Now click on ">" for more pinned apps and observe

Expected: No border of overview mode window should be seen on shelf.
Actual: Instead border of window is seen on shelf.

This is a regression issue as same is working fine in 53.0.2785.100/8530.80.0 quawks.

NOTE: Small guess is shelf became more transparent than before.

@varkha: Please confirm the behavior.
Expected_icons.png
506 KB View Download
Actual_app icons.png
664 KB View Download

Comment 1 by ajha@chromium.org, Sep 8 2016

Labels: ReleaseBlock-Stable
Issue is reproducible on 55.0.2852.0/8780.0.0 dev channel_Falco

Comment 2 by varkha@chromium.org, Sep 8 2016

Labels: Proj-MaterialDesign-CrOS
Status: Started (was: Assigned)
My guess would be that this is shadows that were introduced in https://codereview.chromium.org/2150823002/ (r405932). I have a draft that (a) makes shadows an experimental except for a more visible selector shadow and (b) changes stacking order which would put the shadows (along with the window headers) in the same plane as the windows in overview and below the shelf. That patch is at https://codereview.chromium.org/2239233002/.

Note: It is not just the shadows, the caption text is also above the shelf which is wrong (see attached screenshot).
Screenshot 2016-09-08 at 12.19.39.png
58.2 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5d0098acc9a8167409476627eae3e91d94e8cac

commit f5d0098acc9a8167409476627eae3e91d94e8cac
Author: varkha <varkha@chromium.org>
Date: Fri Sep 09 22:06:20 2016

[ash-md] Fades overview header in and out

This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec.

This creates a visually smoother transition into overview mode than before.

Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item.

BUG= 624608 ,  645076 
TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt.

Review-Url: https://codereview.chromium.org/2239233002
Cr-Commit-Position: refs/heads/master@{#417728}

[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/aura/wm_window_aura.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/default_header_painter.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/header_view.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/header_view.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/overview_animation_type.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/scoped_overview_animation_settings.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm_window.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm_window_property.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/overview/scoped_overview_animation_settings_aura.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/overview/scoped_overview_animation_settings_aura.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ui/aura/client/aura_constants.h

Comment 4 by varkha@chromium.org, Sep 9 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/758e34e4a30be65c2cedf5fb2a893fa3a87596f0

commit 758e34e4a30be65c2cedf5fb2a893fa3a87596f0
Author: dmurph <dmurph@chromium.org>
Date: Sat Sep 10 01:50:58 2016

Revert of [ash-md] Fades overview header in and out (patchset #17 id:400001 of https://codereview.chromium.org/2239233002/ )

Reason for revert:
This is causing a use-after-free and crashing stuff :(

BUG= 645708 

Original issue's description:
> [ash-md] Fades overview header in and out
>
> This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec.
>
> This creates a visually smoother transition into overview mode than before.
>
> Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item.
>
> BUG= 624608 ,  645076 
> TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt.
>
> Committed: https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac
> Cr-Commit-Position: refs/heads/master@{#417728}

TBR=sky@chromium.org,bruthig@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 624608 ,  645076 

Review-Url: https://codereview.chromium.org/2329433003
Cr-Commit-Position: refs/heads/master@{#417796}

[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/aura/wm_window_aura.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/default_header_painter.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/header_view.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/header_view.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/overview_animation_type.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/scoped_overview_animation_settings.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm_window.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm_window_property.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/overview/scoped_overview_animation_settings_aura.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/overview/scoped_overview_animation_settings_aura.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ui/aura/client/aura_constants.h
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc9b9dfb7982cf069897b750a76231ab5bb2e31

commit ebc9b9dfb7982cf069897b750a76231ab5bb2e31
Author: varkha <varkha@chromium.org>
Date: Mon Sep 12 20:07:30 2016

Reland of [ash-md] Fades overview header in and out

This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec.

This creates a visually smoother transition into overview mode than before.

Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item.

---

This relands https://codereview.chromium.org/2239233002/ and
reverts commit 758e34e4a30be65c2cedf5fb2a893fa3a87596f0.

Corrects lifetime manipulation of the child views after their
ownership it taken over by a CleanupAnimationObserver.

BUG= 624608 ,  645076 ,  645708 
TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt.

Review-Url: https://codereview.chromium.org/2336673002
Cr-Commit-Position: refs/heads/master@{#418017}

[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/aura/wm_window_aura.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/default_header_painter.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/header_view.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/header_view.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/overview_animation_type.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/scoped_overview_animation_settings.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm_window.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm_window_property.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/overview/scoped_overview_animation_settings_aura.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/overview/scoped_overview_animation_settings_aura.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ui/aura/client/aura_constants.h

Comment 7 by rookrishna@chromium.org, Sep 22 2016

Status: Verified (was: Fixed)
Version 55.0.2866.0 dev (64-bit)
Platform 8825.0.0 (Official Build) dev-channel samus
►

Sign in to add a comment