As we will add more work arounds in ANGLE to fix graphics driver bugs, 32-bits compile options cannot satisfy the needs. It's time to make it 64-bits.
Could you elaborate on the problem? ANGLE compiles for the same architectures as Chromium
This is about the ANGLE's compiler compile options bitfield running out of space with all the new workarounds.
Ok, thanks.
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/7ebb97fc9a51aad770e07ee10de420b5fbc2a278 commit 7ebb97fc9a51aad770e07ee10de420b5fbc2a278 Author: Qiankun Miao <qiankun.miao@intel.com> Date: Thu Sep 08 10:01:50 2016 Use 64-bits compile options BUG= chromium:645071 Change-Id: I31825123bf4cb45fb37a93f538e8936487beb5ff Reviewed-on: https://chromium-review.googlesource.com/382712 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/Shader.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/Compiler.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/tests/compiler_tests/MalformedShader_test.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/Compiler.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/TranslatorESSL.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/renderer/gl/ShaderGL.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/renderer/d3d/ShaderD3D.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/TranslatorGLSL.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/OutputHLSL.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/renderer/d3d/ShaderD3D.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/TranslatorESSL.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/OutputHLSL.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/renderer/vulkan/ShaderVk.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/renderer/gl/ShaderGL.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/samples/shader_translator/shader_translator.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/TranslatorHLSL.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/renderer/ShaderImpl.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/ShaderLang.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/tests/test_utils/compiler_test.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/tests/compiler_tests/ExpressionLimit_test.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/tests/test_utils/compiler_test.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/include/GLSLANG/ShaderLang.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/TranslatorHLSL.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/TranslatorGLSL.cpp [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/libANGLE/renderer/vulkan/ShaderVk.h [modify] https://crrev.com/7ebb97fc9a51aad770e07ee10de420b5fbc2a278/src/compiler/translator/ParseContext.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d4e2b3155891e73d73f9c76f84ab19cffdcc155 commit 0d4e2b3155891e73d73f9c76f84ab19cffdcc155 Author: qiankun.miao <qiankun.miao@intel.com> Date: Wed Sep 14 00:16:49 2016 Roll ANGLE 47cb73a..7ebb97f https://chromium.googlesource.com/angle/angle.git/+log/47cb73a..7ebb97f BUG= chromium:645071 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2336213003 Cr-Commit-Position: refs/heads/master@{#418433} [modify] https://crrev.com/0d4e2b3155891e73d73f9c76f84ab19cffdcc155/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80732c60811ff35ddb3b60d4f6cd4cbdfeecf5bc commit 80732c60811ff35ddb3b60d4f6cd4cbdfeecf5bc Author: qiankun.miao <qiankun.miao@intel.com> Date: Wed Sep 14 09:25:30 2016 Use 64-bits shader compile options BUG= 645071 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2321953002 Cr-Commit-Position: refs/heads/master@{#418518} [modify] https://crrev.com/80732c60811ff35ddb3b60d4f6cd4cbdfeecf5bc/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/80732c60811ff35ddb3b60d4f6cd4cbdfeecf5bc/gpu/command_buffer/service/shader_translator.cc [modify] https://crrev.com/80732c60811ff35ddb3b60d4f6cd4cbdfeecf5bc/gpu/command_buffer/service/shader_translator.h
Comment 1 by geoffl...@chromium.org
, Sep 8 2016