New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 645043 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 635528
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

RGB8 multisample renderbuffer doesn't work on MacOSX

Project Member Reported by jie.a.c...@intel.com, Sep 8 2016

Issue description

Version: TOT chromium + MacOSX 10.11.6


What steps will reproduce the problem?
(1) open chrome with command line: --enable-unsafe-es3-apis on Mac with an Intel integrated graphics card. 
(2) Open https://www.khronos.org/registry/webgl/sdk/tests/deqp/functional/gles3/fbomultisample.8_samples.html?webglVersion=2 or https://www.khronos.org/registry/webgl/sdk/tests/conformance2/rendering/rgb-format-support.html?webglVersion=2 

What is the expected output? 
The RGB8 cases should pass.

What do you see instead? 
These tests fail. 

 
Cc: kbr@chromium.org zmo@chromium.org qiankun....@intel.com yunchao...@intel.com
Mergedinto: 635528
Status: Duplicate (was: Started)
Status: Assigned (was: Duplicate)
635528 is for Linux Intel.

Comment 4 by kbr@chromium.org, Sep 10 2016

Components: Blink>WebGL Internals>GPU>Internals
https://codereview.chromium.org/2328463002/ is up for review which fixes (all of? some of?) the problems here.

It looks to me like the earlier-filed Issue 641209 is a duplicate of this. Since the CL above refers to this bug, we should probably duplicate the other bug into this one.

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/361419c87294053f0fd1701431053d19253710e5

commit 361419c87294053f0fd1701431053d19253710e5
Author: jie.a.chen <jie.a.chen@intel.com>
Date: Sat Sep 10 10:41:00 2016

The formats of read and draw framebuffers should be identical according to spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG= 645043 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2328463002
Cr-Commit-Position: refs/heads/master@{#417831}

[modify] https://crrev.com/361419c87294053f0fd1701431053d19253710e5/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/361419c87294053f0fd1701431053d19253710e5/gpu/command_buffer/service/gles2_cmd_decoder.cc

Comment 6 by kbr@chromium.org, Sep 13 2016

Cc: kainino@chromium.org jie.a.c...@intel.com
Issue 641209 has been merged into this issue.

Comment 7 by kbr@chromium.org, Sep 13 2016

Status: Started (was: Assigned)
Is this fully fixed? Please mark Fixed if so. Thanks.

Status: Fixed (was: Started)
Okay, Done!
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89fa127b5acf4dcfb8f8fca468adf10ce4c00a84

commit 89fa127b5acf4dcfb8f8fca468adf10ce4c00a84
Author: jchen10 <jie.a.chen@intel.com>
Date: Tue Mar 06 12:14:19 2018

Use glTexImage2D to verify renderbuffer integrity.

glTexStorage2DEXTFn requires GL > 4.2 or GL_ARB_texture_storage,
as may not be always available.

Bug: 815051, 645043 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5a509051b53385df9cf39a2cffb88661849805a0
Reviewed-on: https://chromium-review.googlesource.com/948362
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541078}
[modify] https://crrev.com/89fa127b5acf4dcfb8f8fca468adf10ce4c00a84/gpu/command_buffer/service/gles2_cmd_decoder.cc

Sign in to add a comment