"NavigationControllerBrowserTest.RaceCrossOriginNavigationAndSamePageHistoryNavigation" is flaky |
||||||||
Issue description"NavigationControllerBrowserTest.RaceCrossOriginNavigationAndSamePageHistoryNavigation" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYAsSBUZsYWtlIlVOYXZpZ2F0aW9uQ29udHJvbGxlckJyb3dzZXJUZXN0LlJhY2VDcm9zc09yaWdpbk5hdmlnYXRpb25BbmRTYW1lUGFnZUhpc3RvcnlOYXZpZ2F0aW9uDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 8 2016
I'll disable the test for now. The CL has very useful functionality that should remain in the code.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606b88d976dba0e9a6ba09a267ed730572fb7fc3 commit 606b88d976dba0e9a6ba09a267ed730572fb7fc3 Author: nasko <nasko@chromium.org> Date: Thu Sep 08 17:49:21 2016 Disable RaceCrossOriginNavigationAndSamePageHistoryNavigation due to flakiness. BUG= 645022 , 630103 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2316263004 Cr-Commit-Position: refs/heads/master@{#417333} [modify] https://crrev.com/606b88d976dba0e9a6ba09a267ed730572fb7fc3/content/browser/frame_host/navigation_controller_impl_browsertest.cc
,
Sep 8 2016
,
Sep 9 2016
Detected 5 new flakes for test/step "NavigationControllerBrowserTest.RaceCrossOriginNavigationAndSamePageHistoryNavigation". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYAsSBUZsYWtlIlVOYXZpZ2F0aW9uQ29udHJvbGxlckJyb3dzZXJUZXN0LlJhY2VDcm9zc09yaWdpbk5hdmlnYXRpb25BbmRTYW1lUGFnZUhpc3RvcnlOYXZpZ2F0aW9uDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Sep 12 2016
I can't see any new alerts since Sept 8.
,
Sep 12 2016
I have only disabled the test, not fixed the flakiness. Reopening, so the underlying issue can still be tracked and resolved.
,
Sep 13 2016
Last flake (#417322) was before the revert (#417333) obviously, taking this out of sheriff queue.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29b2a5a88cf2c558d67e2befaeb5d2bb9ecdfd36 commit 29b2a5a88cf2c558d67e2befaeb5d2bb9ecdfd36 Author: nasko <nasko@chromium.org> Date: Tue Sep 27 00:06:03 2016 Deflake RaceCrossOriginNavigationAndSamePageHistoryNavigation test. This test was dropping the commit IPC message, which casued some flaky runs. The fix for that is to not drop the message, but to still process it and ensure it issues a GoBack navigation command before it is processed. This CL also introduces a new observer object that can track only a commit of a specific URL in a frame. BUG= 645022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2377453002 Cr-Commit-Position: refs/heads/master@{#421044} [modify] https://crrev.com/29b2a5a88cf2c558d67e2befaeb5d2bb9ecdfd36/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/29b2a5a88cf2c558d67e2befaeb5d2bb9ecdfd36/content/test/content_browser_test_utils_internal.cc [modify] https://crrev.com/29b2a5a88cf2c558d67e2befaeb5d2bb9ecdfd36/content/test/content_browser_test_utils_internal.h
,
Sep 28 2016
This should be fixed now. Open a new bug if the test starts flaking again. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by gogerald@chromium.org
, Sep 8 2016