New issue
Advanced search Search tips

Issue 644998 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Crash: settings::SiteSettingsHandler::HandleResetCategoryPermissionForOrigin

Project Member Reported by sheriffbot@chromium.org, Sep 8 2016

Issue description

Crash Signature: settings::SiteSettingsHandler::HandleResetCategoryPermissionForOrigin
Process Type: Browser
Platform: Win
Channel: Canary
Version: 55.0.2853.0
Distinct Clients: 3
CPM: 0.35
Crash Reports: 5
Median Uptime: 03m:44s
Infected Clients: 0.0%

Sample Reports:
https://crash.corp.google.com/browse?q=reportid=%2727ce303500000000%27

Crash Link:
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2755.0.2853.0%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27settings%3A%3ASiteSettingsHandler%3A%3AHandleResetCategoryPermissionForOrigin%27

Crash Link (with version impact distribution):
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27settings%3A%3ASiteSettingsHandler%3A%3AHandleResetCategoryPermissionForOrigin%27

Crash Stacktrace:
ACCESS_VIOLATION_WRITE (0x0)
#0 0x7ff993ba3533 in settings::SiteSettingsHandler::HandleResetCategoryPermissionForOrigin chrome/browser/ui/webui/settings/site_settings_handler.cc:431
#1 0x7ff9929787bf in content::WebUIImpl::ProcessWebUIMessage content/browser/webui/web_ui_impl.cc:254
#2 0x7ff992977f13 in content::WebUIImpl::OnWebUISend content/browser/webui/web_ui_impl.cc:108
#3 0x7ff992978c5c in IPC::MessageT<ViewHostMsg_WebUISend_Meta,std::tuple<GURL,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>,void>::Dispatch<content::WebUIImpl,content::WebUIImpl,void,void ipc/ipc_message_templates.h:121
#4 0x7ff992977e58 in content::WebUIImpl::OnMessageReceived content/browser/webui/web_ui_impl.cc:91
#5 0x7ff99295b469 in content::WebContentsImpl::OnMessageReceived content/browser/web_contents/web_contents_impl.cc:653
#6 0x7ff9928a4e14 in content::RenderViewHostImpl::OnMessageReceived content/browser/renderer_host/render_view_host_impl.cc:838
#7 0x7ff9928aa85a in content::RenderWidgetHostImpl::OnMessageReceived content/browser/renderer_host/render_widget_host_impl.cc:459
#8 0x7ff99289b54f in content::RenderProcessHostImpl::OnMessageReceived content/browser/renderer_host/render_process_host_impl.cc:1967
#9 0x7ff9933dedff in IPC::ChannelProxy::Context::OnDispatchMessage ipc/ipc_channel_proxy.cc:327
#10 0x7ff992cdca72 in base::debug::TaskAnnotator::RunTask base/debug/task_annotator.cc:54
#11 0x7ff992c6ec67 in base::MessageLoop::RunTask base/message_loop/message_loop.cc:488
#12 0x7ff992c6fc44 in base::MessageLoop::DoWork base/message_loop/message_loop.cc:621
#13 0x7ff992cdd367 in base::MessagePumpForUI::DoRunLoop base/message_loop/message_pump_win.cc:262
#14 0x7ff992cdd033 in base::MessagePumpWin::Run base/message_loop/message_pump_win.cc:140
#15 0x7ff992cc7c3c in base::RunLoop::Run base/run_loop.cc:35
#16 0x7ff992bd9223 in ChromeBrowserMainParts::MainMessageLoopRun chrome/browser/chrome_browser_main.cc:2098
#17 0x7ff9926b6b3c in content::BrowserMainRunnerImpl::Run content/browser/browser_main_runner.cc:155
#18 0x7ff9926af6be in content::BrowserMain content/browser/browser_main.cc:46
#19 0x7ff992b8a3ca in content::ContentMainRunnerImpl::Run content/app/content_main_runner.cc:786
#20 0x7ff991d22ba6 in ChromeMain chrome/app/chrome_main.cc:85
#21 0x7ff712fe7846 in MainDllLoader::Launch chrome/app/main_dll_loader_win.cc:168
#22 0x7ff712fe2374 in wWinMain chrome/app/chrome_exe_main_win.cc:246
#23 0x7ff7132aa009 in __scrt_common_main_seh startup/exe_common.inl:255
#24 0x7ff9fd8a8363 in BaseThreadInitThunk 
#25 0x7ff9ff3c5e90 in RtlUserThreadStart 


Reporter: ajha

 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 8 2016

Labels: OS-Windows FoundIn-M-55
Users experienced this crash on the following builds:

Win Canary 55.0.2853.0 -  0.40 CPM, 6 reports, 3 clients (signature settings::SiteSettingsHandler::HandleResetCategoryPermissionForOrigin)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 2 by ajha@chromium.org, Sep 8 2016

Cc: -ajha@google.com ajha@chromium.org
Components: UI>Settings
Labels: -Type-Bug ReleaseBlock-Stable M-55 Type-Bug-Regression
Owner: finnur@chromium.org
Status: Assigned (was: Untriaged)
This is Windows specific regression crash on M-55 seen from chrome version: 55.0.2852.0.

Considering below as the changelog:
===================================
https://chromium.googlesource.com/chromium/src/+log/55.0.2850.0..55.0.2852.0?pretty=fuller&n=10000

Suspecting: https://codereview.chromium.org/2298283002 for recent 'site_settings_handler.cc' related change.

finnur@: Could you please take a look at these crashes. 
I looked at a crash dump and it shows that the line that is failing is this:

  CHECK(args->GetBoolean(3, &incognito));

So, the CL is related. I just don't know how to repro it -- I tried adding exceptions in all categories and then deleting them, but I couldn't get it to crash. 

My theory is that some content settings don't have an incognito attribute, but I don't know how to come across one of such kind. 

Comment 4 by rsesek@chromium.org, Sep 20 2016

Labels: -Restrict-View-EditIssue OS-Mac
This occurs on Mac as well. The reporter in  issue 648106  has repro steps.

Comment 5 by rsesek@chromium.org, Sep 20 2016

 Issue 648106  has been merged into this issue.

Comment 7 by finnur@chromium.org, Sep 21 2016

Status: Fixed (was: Assigned)

Sign in to add a comment