depot_tools needs a pylint presubmit |
|||||
Issue descriptionTo catch errors like http://o/321132. Assigning to maruel because you did it for infra ages ago.
,
Sep 12 2016
estaab: who owns depot_tools? Can you reassign?
,
Sep 19 2016
depot_tools is unowned but maybe Aaron can help since he may know the easiest way to prevent the typo from https://codereview.chromium.org/2280213002. (otherwise Robbie was my other choice)
,
Sep 22 2016
The pylint check in depot_tools is a total mess. I've cleaned it up and given it a whitelist so that it only checks things that are actually source files, and that actually live in depot_tools (as opposed to being pulled in e.g. by recipes). It is also significantly faster now. https://codereview.chromium.org/2353393004
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/f39c33382a0ddf7b242ebee54a5e3098707d57ca commit f39c33382a0ddf7b242ebee54a5e3098707d57ca Author: agable <agable@chromium.org> Date: Mon Sep 26 16:35:42 2016 Use a whitelist for depot_tools pylint instead R=maruel@chromium.org BUG= 644995 Review-Url: https://codereview.chromium.org/2353393004 [modify] https://crrev.com/f39c33382a0ddf7b242ebee54a5e3098707d57ca/PRESUBMIT.py [modify] https://crrev.com/f39c33382a0ddf7b242ebee54a5e3098707d57ca/cpplint.py
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/642ddc0047581a7ce5f73069b5f0d2020b376a15 commit 642ddc0047581a7ce5f73069b5f0d2020b376a15 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 16:44:08 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/f39c33382a0ddf7b242ebee54a5e3098707d57ca Use a whitelist for depot_tools pylint instead (agable@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 644995 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2370873002 [modify] https://crrev.com/642ddc0047581a7ce5f73069b5f0d2020b376a15/infra/config/recipes.cfg
,
Sep 26 2016
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/8350fd81c39be42d7b142d4ff7f0c8d9402d3743 commit 8350fd81c39be42d7b142d4ff7f0c8d9402d3743 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 17:05:20 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/642ddc0047581a7ce5f73069b5f0d2020b376a15 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/f39c33382a0ddf7b242ebee54a5e3098707d57ca Use a whitelist for depot_tools pylint instead (agable@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 644995 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2369083002 [modify] https://crrev.com/8350fd81c39be42d7b142d4ff7f0c8d9402d3743/infra/config/recipes.cfg
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4f263fae92ad73662a9d18a0889b462e2d753eb commit d4f263fae92ad73662a9d18a0889b462e2d753eb Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 17:09:39 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/642ddc0047581a7ce5f73069b5f0d2020b376a15 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/f39c33382a0ddf7b242ebee54a5e3098707d57ca Use a whitelist for depot_tools pylint instead (agable@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 644995 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2368243004 Cr-Commit-Position: refs/heads/master@{#420914} [modify] https://crrev.com/d4f263fae92ad73662a9d18a0889b462e2d753eb/infra/config/recipes.cfg
,
Sep 26 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/95acda08f39263cbbeec4e9e268c37777dd5e1b6 commit 95acda08f39263cbbeec4e9e268c37777dd5e1b6 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 18:54:44 2016 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mar...@chromium.org
, Sep 9 2016Owner: ----
Status: Available (was: Assigned)