New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644994 link

Starred by 1 user
Status: Duplicate
Merged: issue 643885
Owner: ----
Closed: Sep 2016
Cc:
█ phajdan.jr@chromium.org
hinoka@chromium.org
█ iannucci@chromium.org
tandrii@chromium.org
█ dsansome@chromium.org
aga...@chromium.org
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

bot_update.py needs unit tests

Project Member Reported by dsansome@chromium.org, Sep 8 2016 
depot_tools/recipe_modules/bot_update/resources/bot_update.py needs unit tests.

To catch errors like http://o/321132.

Assigning to phajdan.jr since he created that file, but anyone else feel free to take it

Comment 1 by estaab@chromium.org, Sep 8 2016

Cc: iannucci@chromium.org hinoka@chromium.org
Owner: ----
Status: Available (was: Assigned)
phajdan just moved the file from another location but it was originally done by hinoka, and iannucci is doing some cleanup right now as part of making recipe APIs saner. cc'ed both of them.

bot_update is a huge tool so it's unlikely it will gain good unit test coverage without significant effort. It's more likely that recipes in repos will be done before that and at least we'll catch breaking changes in the CQ.

Comment 2 by dsansome@chromium.org, Sep 8 2016 

> bot_update is a huge tool so it's unlikely it will gain good unit test coverage without significant effort.

Then please let's make a significant effort.  Make it an OKR if necessary.  This script is run by every build on every builder right?  For it not to have unit tests is a huge liability.

Comment 3 by estaab@chromium.org, Sep 8 2016

Mergedinto: 643885
Status: Duplicate (was: Available)
Ok, it turns out this is what Robbie is working on right now since I see bot_update unit testing in the description of his other bug. I'll mark this as duplicate.

Comment 4 by dsansome@chromium.org, Sep 8 2016 

Ah awesome, thanks!
►

Sign in to add a comment