New issue
Advanced search Search tips

Issue 644977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 644351



Sign in to add a comment

Need to make clang build script work with new ndk

Project Member Reported by thakis@chromium.org, Sep 8 2016

Issue description

In  issue 599327  we updated the NDK. Looks like the clang build script disagrees with the new NDK:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_upload_clang/builds/81/steps/package%20clang/logs/stdio

Running /b/build/slave/linux_upload_clang/build/src/third_party/android_tools/ndk/build/tools/make-standalone-toolchain.sh --platform=android-21 '--install-dir="/b/build/slave/linux_upload_clang/build/src/third_party/llvm-build/Release+Asserts/android-toolchain-aarch64"' --system=linux-x86_64 --stl=stlport --toolchain=aarch64-linux-android-4.9
WARNING: make-standalone-toolchain.sh will be removed in r13. Please try make_standalone_toolchain.py now to make sure it works for your needs.
HOST_OS=linux
HOST_EXE=
HOST_ARCH=x86_64
HOST_TAG=linux-x86_64
HOST_NUM_CPUS=32
BUILD_NUM_CPUS=64
ERROR: Unknown option '--system'. See --help for usage.


I guess we should try using the .py script first and see if it does the trick for us.
 
Yeah, probably.

Re --system: looks like it has a default value that we could previously override (https://chromium.googlesource.com/android_tools/+/af1c5a4cd6329ccdcf8c2bc93d9eea02f9d74869/ndk/build/tools/make-standalone-toolchain.sh#49).
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9ed3eadc79673e746507158cfbdf2651961af6f

commit e9ed3eadc79673e746507158cfbdf2651961af6f
Author: thakis <thakis@chromium.org>
Date: Fri Sep 09 03:16:04 2016

Roll clang 280106:280836.

New:
* win: Speculative fix for LNK1285/delete-pdb-and-rebuild
* win: Support for [] ATL-style uuid() attributes
* win: __nop intrinsic now has a definition
* win: complete codeview debug info for vptrs

Also switch to gnuwin-5, which is identical to gnuwin-4
except that it has gnuwin32's od.exe too.

Also switch to the python version of the Android NDK
"make standalone toolchain" script, since the .sh version
is deprecated and stopped working after the recent NDK
update.

BUG= 644351 , 644976 , 644977 

Review-Url: https://codereview.chromium.org/2317123004
Cr-Commit-Position: refs/heads/master@{#417492}

[modify] https://crrev.com/e9ed3eadc79673e746507158cfbdf2651961af6f/tools/clang/scripts/update.py

Status: Fixed (was: Untriaged)
Owner: thakis@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fb78780cf8731e6e2e85d8215b26716c8cd1ad5

commit 4fb78780cf8731e6e2e85d8215b26716c8cd1ad5
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 12 14:45:35 2016

clang build script: Clobber old Android toolchains.

https://codereview.chromium.org/2317123004 switched the Android bits of
the script to the new .py script.  That script needs an explicit --force
flag to clobber old Android toolchains, else it errors out with

  Running make_standalone_toolchain.py --api=21 --install-dir=... --stl=stlport --arch=arm64
  Installation directory already exists. Use --force.
  Failed.

if the --install-dir already exists (for example, from a previous build).

BUG= 644977 
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/2336463003 .

Cr-Commit-Position: refs/heads/master@{#417938}

[modify] https://crrev.com/4fb78780cf8731e6e2e85d8215b26716c8cd1ad5/tools/clang/scripts/update.py

Sign in to add a comment