Media Router icon gets pressed on the wrong toolbar |
||
Issue descriptionVersion: M53/54 What steps will reproduce the problem? (1) Have Media Router enabled and the Cast icon on the toolbar (2) Open a window with two tabs, and drag one of the tabs out to create a new window (3) Click on the Cast icon in the new window. The icon in the original window gets depressed.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a9c22d4d0a3c4335d69d00f28a8895d9583bab1 commit 0a9c22d4d0a3c4335d69d00f28a8895d9583bab1 Author: takumif <takumif@chromium.org> Date: Thu Sep 08 19:59:33 2016 Allow MediaRouterDialogControllerImpl to re-set its reference to MRAction When a tab that a dialog controller is associated with gets moved to another window, we need to allow the dialog controller to update its reference to the toolbar action (associated with a window). This fixes the bug in which the icon gets pressed in a wrong window. The comment for SetMediaRouterAction() is also updated, as it is okay for the action to be null, and we expect it to become null when it gets removed from the toolbar. BUG= 644972 Review-Url: https://codereview.chromium.org/2321163002 Cr-Commit-Position: refs/heads/master@{#417376} [modify] https://crrev.com/0a9c22d4d0a3c4335d69d00f28a8895d9583bab1/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc [modify] https://crrev.com/0a9c22d4d0a3c4335d69d00f28a8895d9583bab1/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h
,
Sep 9 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by taku...@chromium.org
, Sep 8 2016