New issue
Advanced search Search tips

Issue 644959 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GRIT expansion introduces spurious whitespace

Project Member Reported by drcrash@chromium.org, Sep 8 2016

Issue description

Let's say you have this:

  <message name="NAME" desc="Some desc.">
    This happened on this site: <ph name="BEGIN_BOLD">&lt;strong&gt;</ph><ph name="DOMAIN">$1<ex>acmecorp.com</ex></ph><ph name="END_BOLD">&lt;/strong&gt;</ph>.
  </message>

Then GRIT will expand this into (as seen once put as innerHTML):

"This happened on this site: "
<strong>site.com</strong>
"."

Which renders with whitespace between site.com and the final period.

GRIT should never add a carriage return after </ph> and before whatever is next.

This contributes to a number of UI messages in Chromium/Chromium OS looking odd because of typesetting issues.
 
Do you have a specific example to test with?
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment