New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644957 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Update Chrome's handling of deleted WebGL objects to newly specified behavior

Project Member Reported by kbr@chromium.org, Sep 8 2016

Issue description

The WebGL specification was recently revised to generate an INVALID_OPERATION error when attempting to bind a deleted object: https://github.com/KhronosGroup/WebGL/pull/2002 .

Chrome's implementation needs to be updated to do this rather than its current behavior, which is to silently treat this as unbinding the object in question.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7630800e91abbb104e76515b92e682e189ca1e

commit ef7630800e91abbb104e76515b92e682e189ca1e
Author: jiawei.shao <jiawei.shao@intel.com>
Date: Mon Sep 12 06:03:32 2016

Generate INVALID_OPERATION error when attempting to bind a deleted object

According to the new spec, a INVALID_OPERATION error should be generated
when attemping to call bind* function on a delete object and the origin
binding should be keeped, including buffers, textures, renderbuffers and
framebuffers.

BUG= chromium:644957 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2322943002
Cr-Commit-Position: refs/heads/master@{#417875}

[modify] https://crrev.com/ef7630800e91abbb104e76515b92e682e189ca1e/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/ef7630800e91abbb104e76515b92e682e189ca1e/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/ef7630800e91abbb104e76515b92e682e189ca1e/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/ef7630800e91abbb104e76515b92e682e189ca1e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Comment 2 by kbr@chromium.org, Sep 15 2016

Cc: jiawei.s...@intel.com
Labels: OS-All
Owner: jiawei.s...@intel.com
Status: Assigned (was: Available)
Thank you Jiawei for your nice contribution above. Is this fully fixed at this point?

I think the issue has been fully fixed with my patch since WebGL2 CTS conformance/misc/object-deletion-behaviour.html and conformance2/misc/object-deletion-behaviour-2.html can pass now.

Comment 4 by kbr@chromium.org, Sep 16 2016

Status: Fixed (was: Assigned)
Great. Thank you Jiawei!

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2367caaefaa649d2f852c2069ad859f45f26f06a

commit 2367caaefaa649d2f852c2069ad859f45f26f06a
Author: kbr <kbr@chromium.org>
Date: Thu Sep 22 05:26:38 2016

Remove a few unnecessary Mac and Mac/AMD suppressions.

These have already been dealt with.

BUG= 483282 ,  644957 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2366483002
Cr-Commit-Position: refs/heads/master@{#420266}

[modify] https://crrev.com/2367caaefaa649d2f852c2069ad859f45f26f06a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Sign in to add a comment