New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644953 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Elderberry - Support closing tabs via X button pre-L

Project Member Reported by tedc...@chromium.org, Sep 7 2016

Issue description

Prior to Android L, there was no concept of finishAndRemoveTask, so see if there is some workaround for that pre-L.
 
Labels: -Restrict-View-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d00b3ba347020384d05fd59c319e74a46616443

commit 6d00b3ba347020384d05fd59c319e74a46616443
Author: tedchoc <tedchoc@chromium.org>
Date: Thu Sep 08 01:27:06 2016

Add workaround to remove elderberry tabs from recents (pre-L).

BUG= 644953 

Review-Url: https://codereview.chromium.org/2319963002
Cr-Commit-Position: refs/heads/master@{#417146}

[modify] https://crrev.com/6d00b3ba347020384d05fd59c319e74a46616443/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskManagedCustomTabActivity.java

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d00b3ba347020384d05fd59c319e74a46616443

commit 6d00b3ba347020384d05fd59c319e74a46616443
Author: tedchoc <tedchoc@chromium.org>
Date: Thu Sep 08 01:27:06 2016

Add workaround to remove elderberry tabs from recents (pre-L).

BUG= 644953 

Review-Url: https://codereview.chromium.org/2319963002
Cr-Commit-Position: refs/heads/master@{#417146}

[modify] https://crrev.com/6d00b3ba347020384d05fd59c319e74a46616443/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskManagedCustomTabActivity.java

Status: Fixed (was: Started)

Comment 5 by k...@chromium.org, Sep 15 2016

Labels: ReleaseBlock-Stable
Marking as RBS because it fixes experience for pre-L Herb and Herb is launching in m54.
Labels: Merge-Request-54

Comment 7 by dimu@chromium.org, Sep 15 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 15 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcef85815603a0b2821e47ce79550b37ccfaa72f

commit fcef85815603a0b2821e47ce79550b37ccfaa72f
Author: Ted Choc <tedchoc@google.com>
Date: Thu Sep 15 20:18:53 2016

Add workaround to remove elderberry tabs from recents (pre-L).

BUG= 644953 

Review URL: https://codereview.chromium.org/2341143003 .

Review-Url: https://codereview.chromium.org/2319963002
Cr-Original-Commit-Position: refs/heads/master@{#417146}
Cr-Commit-Position: refs/branch-heads/2840@{#381}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/fcef85815603a0b2821e47ce79550b37ccfaa72f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskManagedCustomTabActivity.java

Status: verified (was: Fixed)
Verified fix in 54.0.2840.33 and also 55.0.2855.3. Thanks!
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcef85815603a0b2821e47ce79550b37ccfaa72f

commit fcef85815603a0b2821e47ce79550b37ccfaa72f
Author: Ted Choc <tedchoc@google.com>
Date: Thu Sep 15 20:18:53 2016

Add workaround to remove elderberry tabs from recents (pre-L).

BUG= 644953 

Review URL: https://codereview.chromium.org/2341143003 .

Review-Url: https://codereview.chromium.org/2319963002
Cr-Original-Commit-Position: refs/heads/master@{#417146}
Cr-Commit-Position: refs/branch-heads/2840@{#381}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/fcef85815603a0b2821e47ce79550b37ccfaa72f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskManagedCustomTabActivity.java

Sign in to add a comment