Issue 644943 link

Starred by 3 users

Issue metadata

Status:	Verified
Owner:	jianli@chromium.org
Closed:	Sep 2016
Cc:	█ dim...@chromium.org fgor...@chromium.org █ talo@chromium.org
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
M-54 Hotlist-Merge-Approved merge-merged-2840

Opening a downloaded page and refreshing it does not bring up the live version when network is connected

Project Member Reported by jianli@chromium.org, Sep 7 2016

Issue description

Version: Canary/Dev
OS: Android

What steps will reproduce the problem?
(1) Make sure the network is always connected
(2) Download a page
(3) Go to Download home and open the downloaded page. The downloaded page should be opened.
(4) Press Reload button to refresh current page.

What is the expected output?
It is expected that online page should be shown.

What do you see instead?
Instead, the offline page is still shown.

Note that we do bring up the online page when the user hits "Reload" link in the snackbar.

Comment 1 by talo@chromium.org, Sep 15 2016

Hey Jian. Just wanted to check in on the timeline for this and if 54 is still looking good! Let me know if there are any questions!

Comment 2 by jianli@chromium.org, Sep 16 2016

Issue 642708 has been merged into this issue.

Comment 3 by jianli@chromium.org, Sep 16 2016

Status: Started (was: Assigned)

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f68c52f414b7b785720faf53458df2517e921c9e

commit f68c52f414b7b785720faf53458df2517e921c9e
Author: jianli <jianli@chromium.org>
Date: Tue Sep 20 22:10:00 2016

Load live version when reloading an offline page on connected network

In order to trigger reloading currently-displayed as offline page with
network condition check, we resend the request with same extra request
header with reason field updated.

BUG= 644943 

Review-Url: https://codereview.chromium.org/2337363002
Cr-Commit-Position: refs/heads/master@{#419868}

[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/BUILD.gn
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_bridge.h
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_request_job.h
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_tab_helper.h
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/components/BUILD.gn
[add] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/components/offline_pages/request_header/BUILD.gn
[add] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/components/offline_pages/request_header/offline_page_header.cc
[add] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/components/offline_pages/request_header/offline_page_header.h
[add] https://crrev.com/f68c52f414b7b785720faf53458df2517e921c9e/components/offline_pages/request_header/offline_page_header_unittest.cc

Comment 5 by dim...@chromium.org, Sep 21 2016

Labels: -M-55 M-54 Merge-Request-54

Comment 6 by dimu@chromium.org, Sep 21 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M54 (branch: 2840)

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 2016

Labels: -merge-approved-54 merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/910386ff9b57445af8966322a34fe578dbba6681

commit 910386ff9b57445af8966322a34fe578dbba6681
Author: Jian Li <jianli@chromium.org>
Date: Wed Sep 21 19:55:48 2016

Merge M54: Load live version when reloading an offline page on connected network

In order to trigger reloading currently-displayed as offline page with
network condition check, we resend the request with same extra request
header with reason field updated.

BUG= 644943 

Review-Url: https://codereview.chromium.org/2337363002
Cr-Commit-Position: refs/heads/master@{#419868}
(cherry picked from commit f68c52f414b7b785720faf53458df2517e921c9e)

Review URL: https://codereview.chromium.org/2363453002 .

Cr-Commit-Position: refs/branch-heads/2840@{#471}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/BUILD.gn
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_bridge.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_request_job.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_tab_helper.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/BUILD.gn
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/BUILD.gn
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/offline_page_header.cc
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/offline_page_header.h
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/offline_page_header_unittest.cc

Comment 8 by jianli@chromium.org, Sep 21 2016

Status: Fixed (was: Started)

Comment 9 by kgna...@chromium.org, Sep 22 2016

Status: Verified (was: Fixed)

Works as per expected behavior, Verified on 55.0.2868.0 and 54.0.2840.35

Comment 10 by dim...@chromium.org, Sep 23 2016

Issue 639279 has been merged into this issue.

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/910386ff9b57445af8966322a34fe578dbba6681

commit 910386ff9b57445af8966322a34fe578dbba6681
Author: Jian Li <jianli@chromium.org>
Date: Wed Sep 21 19:55:48 2016

Merge M54: Load live version when reloading an offline page on connected network

In order to trigger reloading currently-displayed as offline page with
network condition check, we resend the request with same extra request
header with reason field updated.

BUG= 644943 

Review-Url: https://codereview.chromium.org/2337363002
Cr-Commit-Position: refs/heads/master@{#419868}
(cherry picked from commit f68c52f414b7b785720faf53458df2517e921c9e)

Review URL: https://codereview.chromium.org/2363453002 .

Cr-Commit-Position: refs/branch-heads/2840@{#471}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/BUILD.gn
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_bridge.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_request_job.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_tab_helper.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/BUILD.gn
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/BUILD.gn
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/offline_page_header.cc
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/offline_page_header.h
[add] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/components/offline_pages/request_header/offline_page_header_unittest.cc

►

Issue 644943 link

Issue metadata

Opening a downloaded page and refreshing it does not bring up the live version when network is connected

Issue description

Comment 1 by talo@chromium.org, Sep 15 2016

Comment 1 Deleted

Comment 2 by jianli@chromium.org, Sep 16 2016

Comment 2 Deleted

Comment 3 by jianli@chromium.org, Sep 16 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 20 2016

Comment 4 Deleted

Comment 5 by dim...@chromium.org, Sep 21 2016

Comment 5 Deleted

Comment 6 by dimu@chromium.org, Sep 21 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Sep 21 2016

Comment 7 Deleted

Comment 8 by jianli@chromium.org, Sep 21 2016

Comment 8 Deleted

Comment 9 by kgna...@chromium.org, Sep 22 2016

Comment 9 Deleted

Comment 10 by dim...@chromium.org, Sep 23 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

Comment 11 Deleted

Sign in to add a comment