New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644920 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Feature

Blocked on:
issue 644537
issue 645715

Blocking:
issue 609252
issue 646538



Sign in to add a comment

Deploy Mac ASAN bot on chromium.gpu.fyi

Project Member Reported by kbr@chromium.org, Sep 7 2016

Issue description

In  Issue 609252  it's been discovered that there are apparent memory errors leading to TaskObservers being dropped. To catch these sorts of errors earlier while running GPU tests, an ASAN bot is required on the chromium.gpu.fyi waterfall. macOS will be the first target platform.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/78dc34c00e0bf763e2207bd481d416233f6990c1

commit 78dc34c00e0bf763e2207bd481d416233f6990c1
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 08 02:55:10 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/dd201d4c3af933224a9563515766f3eff245f688 Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. (kbr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 644920 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2322863002

[modify] https://crrev.com/78dc34c00e0bf763e2207bd481d416233f6990c1/infra/config/recipes.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43b32af9493cfb8eb561059fb2cb4b8ee87eb44

commit c43b32af9493cfb8eb561059fb2cb4b8ee87eb44
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 08 02:52:12 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/dd201d4c3af933224a9563515766f3eff245f688 Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. (kbr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 644920 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320723004
Cr-Commit-Position: refs/heads/master@{#417174}

[modify] https://crrev.com/c43b32af9493cfb8eb561059fb2cb4b8ee87eb44/infra/config/recipes.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18144abd2d8ece7820f95425faf30aa8a0fa3921

commit 18144abd2d8ece7820f95425faf30aa8a0fa3921
Author: kbr <kbr@chromium.org>
Date: Thu Sep 08 03:34:02 2016

Make per-bot swarming_dimensions an array.

This is in preparation for deploying the Mac ASAN bot, which will spawn
jobs on multiple GPU types.

Add "can_use_on_swarming_builders" flag for non-swarmed
tab_capture_end2end_tests.

This CL is a no-op with regard to the generated JSON files. The next CL
will add the new builder/tester.

BUG= 644920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=dpranke@chromium.org,maruel@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2325533002
Cr-Commit-Position: refs/heads/master@{#417178}

[modify] https://crrev.com/18144abd2d8ece7820f95425faf30aa8a0fa3921/content/test/gpu/generate_buildbot_json.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43b32af9493cfb8eb561059fb2cb4b8ee87eb44

commit c43b32af9493cfb8eb561059fb2cb4b8ee87eb44
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 08 02:52:12 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/dd201d4c3af933224a9563515766f3eff245f688 Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. (kbr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 644920 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320723004
Cr-Commit-Position: refs/heads/master@{#417174}

[modify] https://crrev.com/c43b32af9493cfb8eb561059fb2cb4b8ee87eb44/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18144abd2d8ece7820f95425faf30aa8a0fa3921

commit 18144abd2d8ece7820f95425faf30aa8a0fa3921
Author: kbr <kbr@chromium.org>
Date: Thu Sep 08 03:34:02 2016

Make per-bot swarming_dimensions an array.

This is in preparation for deploying the Mac ASAN bot, which will spawn
jobs on multiple GPU types.

Add "can_use_on_swarming_builders" flag for non-swarmed
tab_capture_end2end_tests.

This CL is a no-op with regard to the generated JSON files. The next CL
will add the new builder/tester.

BUG= 644920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=dpranke@chromium.org,maruel@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2325533002
Cr-Commit-Position: refs/heads/master@{#417178}

[modify] https://crrev.com/18144abd2d8ece7820f95425faf30aa8a0fa3921/content/test/gpu/generate_buildbot_json.py

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4444ef6d703c3efd42f0961c8786aca35f574b7

commit e4444ef6d703c3efd42f0961c8786aca35f574b7
Author: kbr <kbr@chromium.org>
Date: Fri Sep 09 22:47:40 2016

Deploy Mac ASAN bot on chromium.gpu.fyi waterfall.

Refactored mb's mixins for the GPU FYI tests and bots to make this
simpler.

Removed the Mac-10.10 specialization for jobs launched on the MacBook
Pros with AMD GPUs, to allow them to be upgraded to 10.11.

BUG= 641066 ,  644920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=dpranke@chromium.org,zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2320023002
Cr-Commit-Position: refs/heads/master@{#417744}

[modify] https://crrev.com/e4444ef6d703c3efd42f0961c8786aca35f574b7/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/e4444ef6d703c3efd42f0961c8786aca35f574b7/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/e4444ef6d703c3efd42f0961c8786aca35f574b7/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/e4444ef6d703c3efd42f0961c8786aca35f574b7/tools/mb/mb_config.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 10 2016

Comment 10 by kbr@chromium.org, Sep 12 2016

Blocking: 645715

Comment 11 by kbr@chromium.org, Sep 13 2016

Blockedon: 645715
Blocking: -645715

Comment 12 by kbr@chromium.org, Sep 13 2016

Status: Fixed (was: Assigned)
This bot is online and running builds now:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20GPU%20ASAN%20Release

It's quite red and I wonder whether it's uncovering real bugs. I'll file a follow-on bug about investigating the failures on the bot. It looks like either the renderer or GPU process might be crashing based on some of the logs. No stack traces are being generated which is unfortunate.

Comment 13 by kbr@chromium.org, Sep 13 2016

Blocking: 646538

Sign in to add a comment