New issue
Advanced search Search tips

Issue 644915 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 674448
issue 674842
issue 682096

Blocking:
issue 626103



Sign in to add a comment

Remove gnumbd service & related code in git cl and CQ

Project Member Reported by tandrii@chromium.org, Sep 7 2016

Issue description

This is cleanup after gnumbd is finally stopped for V8, Chromium and WebRTC.

and remove all references in docs (e.g. go/chrome-infra-services)
 
Blocking: 626103
Labels: Milestone-Fishfood Proj-Gerrit-Migration
Description: Show this description
Blockedon: 674842 674448
This is blocked on complete migration off gnumbd for 3 projects: v8 (done  issue 674448 ), webrtc(done  issue 674842 ), chromium(tbd,  issue 674936 ).
Status: Started (was: Assigned)
Some of this can already start. Let's wipe out hide_ref_in_committed_msg
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b2b5d0ab5b572a538dbf1793e86bbe321bd92291

commit b2b5d0ab5b572a538dbf1793e86bbe321bd92291
Author: tandrii <tandrii@chromium.org>
Date: Fri Dec 16 16:41:36 2016

CQ config: remove unused hide_ref_in_committed_msg.

This has been superseeded by just-in-time determination based on state
of gnumbd and git-numberer validation.

BUG= chromium:644915 
R=machenbach@chromium.org,sergiyb@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2583703004
Cr-Commit-Position: refs/heads/master@{#41772}

[modify] https://crrev.com/b2b5d0ab5b572a538dbf1793e86bbe321bd92291/infra/config/cq.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e3ac8acdc2868d584b150509ba0693b2c090b56

commit 6e3ac8acdc2868d584b150509ba0693b2c090b56
Author: tandrii <tandrii@chromium.org>
Date: Fri Dec 16 16:47:14 2016

CQ config: remove unused hide_ref_in_committed_msg.

This has been superseeded by just-in-time determination based on state
of gnumbd and git-numberer validation.

BUG= 644915 
R=machenbach@chromium.org,sergiyb@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2583903002
Cr-Commit-Position: refs/heads/master@{#439126}

[modify] https://crrev.com/6e3ac8acdc2868d584b150509ba0693b2c090b56/infra/config/cq.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/8d8816c7b5c2eaf81d6de06b5865015cc0a3fd92

commit 8d8816c7b5c2eaf81d6de06b5865015cc0a3fd92
Author: tandrii <tandrii@chromium.org>
Date: Sat Dec 17 18:20:27 2016

CQ config: remove unused hide_ref_in_committed_msg.

This has been superseeded by just-in-time determination based on state
of gnumbd and git-numberer validation.

BUG= chromium:644915 
R=machenbach@chromium.org,sergiyb@chromium.org,kjellander@chromium.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2576403004
Cr-Commit-Position: refs/heads/master@{#15661}

[modify] https://crrev.com/8d8816c7b5c2eaf81d6de06b5865015cc0a3fd92/infra/config/cq.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/e41898c9bf991cec83db9205053330d89b76ba2f

commit e41898c9bf991cec83db9205053330d89b76ba2f
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Dec 16 16:03:58 2016

gnumbd complete migration has finished 2 weeks ago. Deletion starts...
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/568c8cf46dabae3b73a157e0493203956f45ddea

commit 568c8cf46dabae3b73a157e0493203956f45ddea
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Jan 17 19:49:28 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e081aaf6a5f85bb5afc168b9547980648b70272c

commit e081aaf6a5f85bb5afc168b9547980648b70272c
Author: tandrii <tandrii@chromium.org>
Date: Tue Jan 17 23:37:00 2017

Infra CQ config: remove deprecated target_ref.

BUG= 644915 
R=sergiyb@chromium.org,machenbach@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2643433002
Cr-Commit-Position: refs/heads/master@{#444185}

[modify] https://crrev.com/e081aaf6a5f85bb5afc168b9547980648b70272c/infra/config/cq.cfg

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/9e2d913a85c296a412e05fd522daf04bcf49471b

commit 9e2d913a85c296a412e05fd522daf04bcf49471b
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 02:57:45 2017

Remove gnumbd builders.

R=iannucci@chromium.org
BUG= 644915 

Change-Id: Ia93cc24ae1be6a401c0ded2fbf5458972f61b9fa
Reviewed-on: https://chromium-review.googlesource.com/429510
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/9e2d913a85c296a412e05fd522daf04bcf49471b/masters/master.chromium.infra.cron/master.cfg
[modify] https://crrev.com/9e2d913a85c296a412e05fd522daf04bcf49471b/masters/master.chromium.infra.cron/slaves.cfg

Blockedon: 682096
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/e09c710ce6c04f2cb15b1a0c911e0eab415a4f8e

commit e09c710ce6c04f2cb15b1a0c911e0eab415a4f8e
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 02:59:24 2017

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/81e709df19297c7fbbcdb84c139598b458fe59df

commit 81e709df19297c7fbbcdb84c139598b458fe59df
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 03:16:09 2017

Remove gnumbd tree closing from gatekeeper config.

BUG= 644915 
TBR=stip@chromium.org

Change-Id: I7d795661fcc30e39777ef0d41ebbcbfe4d2a31d3
Reviewed-on: https://chromium-review.googlesource.com/429511
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/81e709df19297c7fbbcdb84c139598b458fe59df/scripts/slave/gatekeeper.json

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/5cc3e495e23d791ded681317a98e0287b0cfe0b0

commit 5cc3e495e23d791ded681317a98e0287b0cfe0b0
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 03:34:13 2017

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/5cc3e495e23d791ded681317a98e0287b0cfe0b0

commit 5cc3e495e23d791ded681317a98e0287b0cfe0b0
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 03:34:13 2017

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/54bcba96dbde84f8c10058b8803483fb78725739

commit 54bcba96dbde84f8c10058b8803483fb78725739
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 18:01:43 2017

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/2d50b8e5da83c8d89742d500698ab5f5c55756e7

commit 2d50b8e5da83c8d89742d500698ab5f5c55756e7
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 03:28:10 2017

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/3c1abd0964020be2f2d13f733f73bb1ce6e9e908

commit 3c1abd0964020be2f2d13f733f73bb1ce6e9e908
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Jan 17 20:14:30 2017

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git/+/05b4baa78d156d299507fbabef99f7c5d879e182

commit 05b4baa78d156d299507fbabef99f7c5d879e182
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 03:42:39 2017

Project Member

Comment 26 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git/+/05b4baa78d156d299507fbabef99f7c5d879e182

commit 05b4baa78d156d299507fbabef99f7c5d879e182
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 03:42:39 2017

Project Member

Comment 27 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/9139c060f7d2e23a900bb2f346fe888f527cf59b

commit 9139c060f7d2e23a900bb2f346fe888f527cf59b
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Jan 18 03:27:11 2017

Retire gnumbd code and mentions of it in this repo.

R=iannucci@chromium.org
BUG= 644915 

Change-Id: I0622d4843893d8233fb6699e99fe944955e3136a
Reviewed-on: https://chromium-review.googlesource.com/429570
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/9139c060f7d2e23a900bb2f346fe888f527cf59b/PRESUBMIT.py
[modify] https://crrev.com/9139c060f7d2e23a900bb2f346fe888f527cf59b/doc/deployment.md
[modify] https://crrev.com/9139c060f7d2e23a900bb2f346fe888f527cf59b/doc/users/contacting_troopers.md
[modify] https://crrev.com/9139c060f7d2e23a900bb2f346fe888f527cf59b/doc/users/services/index.md
[modify] https://crrev.com/9139c060f7d2e23a900bb2f346fe888f527cf59b/go/src/infra/monitoring/analyzer/analyzer.go
[modify] https://crrev.com/9139c060f7d2e23a900bb2f346fe888f527cf59b/infra/services/README.md
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/__init__.py
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/__main__.py
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/gnumbd.py
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/__init__.py
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/bad_position_footer.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/branch.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/branch_from_branch.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/cherry_pick_regression.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/cherry_pick_x_regression.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/enforce_commit_timestamps.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/extra_user_footer.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/extra_user_footer_bad.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/manual_merge_commits_ok.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/master_ahead.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/master_ahead_tag_ahead_pending.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/master_behind.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/master_mismatch_and_pend.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/master_tag_ahead_pending.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/merge_commits_fail.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/multi_pending.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/no_number_on_parent.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/no_pending_tag.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/no_position_footer.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/no_real_ref.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/normal_update.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/normal_with_master_lag.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/push_extra.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/steady_state.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/tag_ahead_master_pending.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/tag_lagging.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.expected/tag_lagging_no_actual.yaml
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test.py
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/test/gnumbd_test_definitions.py
[delete] https://crrev.com/c51dc9cc4dcc5d09d771bf765feb5c3493fd32ac/infra/services/gnumbd/testing_tools/ref_test_combination_finder.py
[modify] https://crrev.com/9139c060f7d2e23a900bb2f346fe888f527cf59b/infra/services/gsubtreed/gsubtreed.py

Project Member

Comment 28 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/f3a20aed8256b4d1983886e1ec4b543f684a9b1e

commit f3a20aed8256b4d1983886e1ec4b543f684a9b1e
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Jan 24 20:23:57 2017

git cl: remove code related to pending refs and gnumbd.

Refactor _GitNumbererState to two functions and remove no longer
useful tests.

BUG= 644915 
R=agable@chromium.org

Change-Id: If5e3e3b141aee192211f6af130b01f20f9afdbfe
Reviewed-on: https://chromium-review.googlesource.com/431976
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f3a20aed8256b4d1983886e1ec4b543f684a9b1e/git_cl.py
[modify] https://crrev.com/f3a20aed8256b4d1983886e1ec4b543f684a9b1e/tests/git_cl_test.py

Status: Fixed (was: Started)

Sign in to add a comment