Document SVGImageForContainer.h and SVGImage.h with class-level comments |
||
Issue descriptionSVGImageForContainer is not completely obvious and we should document why it's needed with a high-level class-level comment in SVGImageForContainer.h. I wrote an old doc on this a long time ago (slightly out of date now) that could be repurposed: https://docs.google.com/document/d/1J3MPhE2nSQz_HQ0Ext6ZIlnMzVCdZbQY9wieR1PA2Tg/view
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bfa5aace01353b25e5e468e759f48df3e010f50 commit 6bfa5aace01353b25e5e468e759f48df3e010f50 Author: pdr <pdr@chromium.org> Date: Fri Sep 09 19:23:00 2016 Document SVGImage with a class-level comment The way SVGImage works is surprising. For example, it is not obvious that we don't use Skia but instead re-use the existing paint pipeline in Blink, nor that SVGImage contains a detached Page. This patch adds some high-level documentation to make these quirks more obvious. Some minor line-wrapping has also been cleaned up. BUG= 644913 NOTRY=true Review-Url: https://codereview.chromium.org/2325733003 Cr-Commit-Position: refs/heads/master@{#417665} [modify] https://crrev.com/6bfa5aace01353b25e5e468e759f48df3e010f50/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
,
Sep 9 2016
+rbyers just fyi, we finally got some light documentation for these classes. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 8 2016